-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Laravel 9/PHP 8.1 #312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
dependencies
Pull requests that update a dependency file
needs review
Pull requests that are pending community review
labels
May 15, 2022
itinerare
force-pushed
the
feature/laravel-9
branch
from
May 15, 2022 16:39
72ec7e9
to
48d70ff
Compare
itinerare
force-pushed
the
feature/laravel-9
branch
from
May 15, 2022 17:13
48d70ff
to
7bf4cf9
Compare
Draginraptor
approved these changes
May 23, 2022
Conflicts: composer.json composer.lock
Sorry for taking a while getting back on this, the required update to PHP 8 set off a chain of...unfortunate events on my local setup. Looks good I think! |
No worries, and sorry to hear about the difficulties! Would that jumping between PHP versions were easier... Thanks for taking a look at it, though! |
itinerare
added
reviewed
Pull requests that have received community review and are pending merge
and removed
needs review
Pull requests that are pending community review
labels
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
reviewed
Pull requests that have received community review and are pending merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Laravel 9 and thus necessarily to require PHP 8. Since PHP 8.1 is the current version, I've just set it there for the moment. No particular impetus for this, but I figure it's easier to keep on top of these things as they come, and I was already updating my other projects/working out what needed adjusting, haha.
Also includes updating to the ignition error page package, which was adopted after Laravel 5 (hence being absent to this point) but has been standard for a while.
Tested locally; requires
composer install
.