Bug:: Issue fix for ItemSlots not being usable #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the check to see if logging succeeds or fails is still relevant so I'd rather it not be removed. I think a better solution might be to have the logging function return true if the user is not staff... |
|
I can do that! I honestly had the same thought but didn't immediately have a solution. |
|
Fair enough! |
itinerare
approved these changes
Jun 19, 2022
preimpression
approved these changes
Jul 1, 2022
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following situation:
createCharacterin the CharacterManager to create the slotcreateCharacteris not staff, so when it tries to log it as an adminAction, it fails.