Fixes/tweaks roundup #350
Merged
Fixes/tweaks roundup #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app/Http/Controllers/Admin/SubmissionController.php
- impacts sites not defined in sites config file
Conflicts: resources/views/pages/credits.blade.php
- adjusts so that there's a min width of 200px
- moves setting var to __construct() in lieu of setting it per-view - this not only resolves some current errors but also removes burden of support from future additions, exts, etc.
…ases - credit to @Ne-wt for the fix itself - change to full reference to DB facade for better static analysis
- also remove redundant get()
Draginraptor
approved these changes
Jul 24, 2022
preimpression
approved these changes
Aug 8, 2022
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's another round of misc stuff that's been accumulating on my fork. Commits should be self-explanatory for reach...
No action necessary, tested locally/live.