Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sidebars to News and Sales #415

Merged
merged 6 commits into from
Oct 9, 2022

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Oct 6, 2022

Sidebars display Recent News/Sales on posts, and 'On This Page' on the index pages.
For Sales specifically, both posts and the index pages also have a section 'For Sale', which are only open sales.

Original inspiration, most of the code and idea by @itinerare.

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Oct 6, 2022
Copy link
Collaborator

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as-is since the changes that I'd want here are both noncritical and the fault of my own past code and I need to kick up a misc PR soonish anyway.

resources/views/sales/_sidebar.blade.php Outdated Show resolved Hide resolved
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Oct 9, 2022
@itinerare itinerare merged commit 6c8c92d into corowne:develop Oct 9, 2022
@SpeedyD SpeedyD deleted the feature/news_sidebars branch October 9, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants