Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bugfixes #43

Merged
merged 21 commits into from
Nov 19, 2020
Merged

Minor bugfixes #43

merged 21 commits into from
Nov 19, 2020

Conversation

itinerare
Copy link
Collaborator

@itinerare itinerare commented Nov 17, 2020 •
edited
Loading

  • Fix bug with deleting a currency used for item entry expansion resale feature (Adds a check when deleting currency for if any items are using the currency for their resale value, regardless of whether or not the feature is currently enabled (just in case).)
  • Fix clearing prompt category description not clearing parsed description

@itinerare
Add css to make images in parsed text not stretch the page, especiall…
1b2340c 
…y on mobile
@itinerare
Merge branch 'master' into main
668df81
@itinerare
Merge branch 'master' into main
eafd376
@itinerare
Swap design/artist name entry to on-site username rather than alias
e0d34fd
@itinerare
Switch art/design user selection to selectize
2f17b94
@itinerare
- Make character image creator user ID nullable
a993a22 
- Add command to convert existing character image creator aliases to on-site user IDs where possible
@itinerare
Adjust art credit ID command to change alias-identified creators with…
f2677cb 
…out associated users to use url instead
@itinerare
Add ability for character image creators to be assigned user IDs on v…
d68c366 
…erification similar to old alias system
@itinerare
Better comments on user model update art/design credit function
d4e655a
@itinerare
- Add a helper function to format user profile links on other sites
6c8d8d4 
- Format art/design credit links using said function
@itinerare
Update masterlist/MYO masterlist artist/designer search for on-site u…
ce2f70b 
…sers
@itinerare
Merge remote-tracking branch 'local/main' into main
c09a59c
@itinerare
Add profile link formatting for instagram
ac54056
@itinerare
Merge remote-tracking branch 'local/main' into main
aa1e4f9
@itinerare
- Make new config file for sites (currently mostly for housing regex)
ee5f37a 
- Change prettyProfileLink function to use said config/condense the code in it
@itinerare
Merge remote-tracking branch 'local/main' into main
1d4aa3e
@itinerare
Fix getting art/designer input on myo ML
3f7dc0e
@itinerare
Merge branch 'develop' into main
68fa05c
@itinerare
Add a check on deleting currency for any items with that currency use…
8e48bcc 
…d for resale value
@itinerare
Adjust check
110abbd
@itinerare itinerare added the needs review Pull requests that are pending community review label Nov 17, 2020
@itinerare
Copy link
Collaborator Author

Not sure why it's included the commits that were recently merged in but 8e48bcc and 110abbd are the relevant ones.

@itinerare itinerare changed the title Fix bug with deleting a currency used for item entry expansion resale feature Minor bugfixes Nov 19, 2020
Sabriel-Koh
Sabriel-Koh approved these changes Nov 19, 2020
View reviewed changes
Copy link

@Sabriel-Koh Sabriel-Koh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!
EDIT: waiT THIS IS WRONG ACCOUNTFKJSF- err, delete this if you want?

Draginraptor
Draginraptor approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right one this time

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Nov 19, 2020
@itinerare itinerare merged commit 6f1ec4f into corowne:develop Nov 19, 2020
@corowne corowne mentioned this pull request Dec 6, 2020
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Draginraptor Draginraptor Draginraptor approved these changes

@preimpression preimpression preimpression approved these changes

@Sabriel-Koh Sabriel-Koh Sabriel-Koh approved these changes

Assignees
No one assigned
Labels
reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@itinerare @Draginraptor @preimpression @Sabriel-Koh