Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing use statement for Facades/View #492

Conversation

Draginraptor
Copy link
Collaborator

@Draginraptor Draginraptor commented Jan 12, 2023

Was updating stuff and got an error on the News page. It's a pretty minor change so I hope I didn't just miss something?

Tested locally.

EDIT: updated to fix the Sales page too.

@itinerare itinerare added the needs review Pull requests that are pending community review label Jan 12, 2023
@itinerare itinerare self-requested a review January 12, 2023 14:27
@itinerare
Copy link
Collaborator

itinerare commented Jan 22, 2023

Realized why, probably: the View::share()s up top in each. god knows why this wasn't a problem before now though

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jan 22, 2023
@itinerare itinerare merged commit e970fb8 into corowne:develop Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants