Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(world): Search traits (and items & prompts) #507

Merged
merged 7 commits into from
Mar 11, 2023
Merged

feat(world): Search traits (and items & prompts) #507

merged 7 commits into from
Mar 11, 2023

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Jan 18, 2023

...by those lacking species, subtypes and categories!

(Items and prompts specifically is category only, obviously.)

NOTE:
Something went wrong with my previous PR, so I redid it. My apologies for the other PR.

@SpeedyD SpeedyD mentioned this pull request Jan 18, 2023
Closed
@itinerare itinerare added the needs review Pull requests that are pending community review label Jan 21, 2023
@itinerare itinerare self-requested a review January 22, 2023 15:10
Draginraptor
Draginraptor reviewed Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "No []" be better as a label? For a bit I was confused since I thought that "No Specific []" was the same as "Any [__]", and was confused by the use of whereNull until it finally clicked for me. This could also be a "just me" thing though.

@itinerare
Copy link
Collaborator

I'd be inclined to agree with that, yeah

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 25, 2023

To be honest, deciding on the function's name has been the one thing I've been hoping to get comments on.

I've actually been thinking about "Without []", but am not sure..

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 25, 2023

@itinerare @Draginraptor
Altered the wording to be "Without []" instead, even altered the variable name to withoutOption for clarification and consistency.

..Feeling a LITTLE dumb about my quick replacing accidentally removing the spacing, but the PHP auto-job picked that up. :)

@SpeedyD SpeedyD requested review from Draginraptor and removed request for itinerare January 25, 2023 16:28
@itinerare itinerare self-requested a review January 25, 2023 16:36
@itinerare itinerare merged commit ff5ea2d into corowne:develop Mar 11, 2023
@itinerare itinerare added enhancement New feature or request reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Mar 11, 2023
@SpeedyD SpeedyD deleted the feature/non-specific-search branch March 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itinerare itinerare itinerare approved these changes

@AW0005 AW0005 AW0005 approved these changes

@Draginraptor Draginraptor Awaiting requested review from Draginraptor

Assignees
No one assigned
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpeedyD @itinerare @Draginraptor @AW0005