add optional aliases #522
Merged
add optional aliases #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
enhancement
itinerare
reviewed
Feb 1, 2023
itinerare
approved these changes
Feb 1, 2023
- system still functions as usual - at least one auth option should be set up
itinerare
approved these changes
Feb 1, 2023
preimpression
approved these changes
Feb 5, 2023
- correctly set has_alias if removing the user's last alias
Conflicts: app/Http/Middleware/CheckAlias.php app/Models/User/User.php app/Services/LinkService.php resources/views/account/aliases.blade.php
AW0005
approved these changes
Mar 11, 2023
Conflicts: app/Http/Middleware/CheckAlias.php resources/views/account/aliases.blade.php
preimpression
approved these changes
Mar 13, 2023
AW0005
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.