Feat(character): Updating previous and next buttons to skip the gaps #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
enhancement
|
On advice from @itinerare, I will be editing the code to be more consistent with other code soon. Please refrain from reviewing until this has been done. Thank you. |
1. Swapped sides by default 2. Added option to reverse 3. Altered configuration to allow new option 4. Actually stopped the code from running if the entire thing is turned off
|
...aaand done. Ready for reviews. |
AW0005
approved these changes
Mar 11, 2023
itinerare
approved these changes
Mar 11, 2023
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been thinking for a while to update the previous and next buttons.. so they no longer skip over the gaps- displaying no previous or next button just because in a sequence of 1-2-4-5 there is no 3, so no previous on 4 and no next on 2.. that's silly.
Spoke about it with @itinerare who quickly produced code, but it required some testing.. and some fixing. And that's what I did.
Also special mention to @AW0005 whose recent edit to the code made me consider doing this. :)