Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(prompts): Category Filter value being set to name #557

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

AW0005
Copy link
Contributor

@AW0005 AW0005 commented Mar 11, 2023

Just a teeny bug fix that I noticed, where the selected category on the prompts filter wasn't "sticking" on clicking search because it's value was being set to name instead.

Copy link
Contributor

@SpeedyD SpeedyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I literally recently changed the EXACT SAME ISSUE for traits! I should've checked if it was the same in prompts. Edit approved.

@AW0005
Copy link
Contributor Author

AW0005 commented Mar 11, 2023

@SpeedyD You saying that made me think to go double check... and I found a few more of them throughout the code base and fixed those up too.

@SpeedyD
Copy link
Contributor

SpeedyD commented Mar 11, 2023

@AW0005 Glad to be of service then! I completely did not think of the admin section..

Which is funny because I am FAIRLY sure I've been having issues with the traits section there.

Copy link
Collaborator

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to see more of these squashed.

@itinerare itinerare merged commit 93907f5 into corowne:develop Mar 11, 2023
@itinerare itinerare added bug Something isn't working reviewed Pull requests that have received community review and are pending merge labels Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants