Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _sidebar.blade.php #612

Merged
merged 4 commits into from
May 30, 2023
Merged

Update _sidebar.blade.php #612

merged 4 commits into from
May 30, 2023

Conversation

Ne-wt
Copy link
Contributor

@Ne-wt Ne-wt commented May 29, 2023

make collapsible

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels May 29, 2023
@SpeedyD
Copy link
Contributor

SpeedyD commented May 29, 2023 •
edited

I'd approve this in a heartbeat.. if the functionality were toggleable.

Could you add a site setting for this, @Ne-wt?

@itinerare
Copy link
Collaborator

Should be a config value, not site setting.

@Ne-wt
Copy link
Contributor Author

Ne-wt commented May 29, 2023

@itinerare done

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels May 30, 2023
@itinerare itinerare merged commit 2ef637a into corowne:develop May 30, 2023
@Ne-wt Ne-wt deleted the patch-1 branch May 30, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preimpression preimpression preimpression approved these changes

@itinerare itinerare itinerare approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ne-wt @SpeedyD @itinerare @preimpression