Bug(Sales): MYO made characters show old MYO image

[AW0005]

Sales image attribute references the "first" image for a character, which means that if you have a character made on a MYO slot with the default image still attached to them, that's what shows up in the sale image instead of the correctly updated active image.

Switching the attribute to reference the attached character's set active image instead fixes it up.

This is somewhere in the grey area of being a bug vs a feature enhancement but I figured it was close enough to unwanted behavior to title it a bug.

[itinerare]

Hmmm. I think probably the thing to do would just to make it toggleable, as I feel strongly that it should remain the "first" image for archival purposes and think having a sales post with a character from a MYO slot profoundly weird, but I also recognize that that is not the beginning and end of use cases for the thing.

[SpeedyD]

I second @itinerare's suggestion. If you add a toggle, this is an instant approve from me. For archival purposes, we'd prefer the old image..

..In all honesty, I feel like there may need to be something more intricate to preserve old sales, but using first is the easiest way to do it rn.

[itinerare]

A potential option re that is recording the image ID at the time the character is added to the sale (probably the best balance between ease-of-use and solving this kind of issue/covers the most use cases most readily), but that would be rather more work than just setting up a toggle.

[SpeedyD]

For now, I'm suggesting @AW0005 just adds a toggle, and maybe we can look into that another time, @itinerare. :)

[itinerare]

Yeah, hence the [or you could just add a toggle and be done with it].

[AW0005]

@itinerare @SpeedyD
Updated to track the character image id at time of sale listing. I wasn't fond of the idea of leaving in something that works by coincidence over going ahead and implementing something that should work as expected for all cases.

[SpeedyD]

...I have nothing to add, I think Merc got everything that needed to be said. 😅

[itinerare]

It gets us all sooner or later. |D