Bug(Design Submission): Duplicated Credits & Saving Credits w/o image #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
bug
itinerare
approved these changes
Jun 22, 2023
SpeedyD
approved these changes
Jun 29, 2023
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things:
If you were in design submission and had supplied an image and artist credits but you got an error (for example by providing an image with a wrong format or an image that was too large) the browser auto-populates the hidden form elements for the credits with what had been previously picked and since those hidden elements were kept inside the form, they would be duplicated on hitting the submit button the second time. So I moved them to be outside of the form.
In the process of fixing the above I realized that I'd get an error if I attempted to only change the credits without uploading a new image, so I fixed that with a better if check on thumbnail processing as well.