Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility reward string creation #668

Merged
merged 12 commits into from
Nov 27, 2023
Merged

Conversation

Ne-wt
Copy link
Contributor

@Ne-wt Ne-wt commented Aug 15, 2023

not implemented anywhere but allows assetArrays to be created as a reward string, using it in pets and seems like something vanilla could use to reduce code repetition

itinerare and others added 6 commits February 2, 2023 19:55
* hotfix: Fixing error with lowercase "auth"

* hotfix: Adding "auth" fix to CommentPolicy
not implemented anywhere but allows assetArrays to be created as a reward string, using it in pets and seems like something vanilla could use to reduce code repetition
@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Aug 15, 2023
@AW0005
Copy link
Contributor

AW0005 commented Aug 15, 2023

Could this possibly be used up front to replace the getBoxRewardString in BoxService?
(And should this be set to be merged into develop rather than main?)

@itinerare
Copy link
Collaborator

Yeah I'd rather either see 1. an implemented use case in core, or 2. a noted use case in another ext before merging it in. And, yeah, this ought to go into develop.

@itinerare itinerare changed the base branch from main to develop August 15, 2023 00:36
@Ne-wt
Copy link
Contributor Author

Ne-wt commented Aug 15, 2023

Could this possibly be used up front to replace the getBoxRewardString in BoxService? (And should this be set to be merged into develop rather than main?)

yeah that would be the intention

@Ne-wt
Copy link
Contributor Author

Ne-wt commented Aug 15, 2023

Yeah I'd rather either see 1. an implemented use case in core, or 2. a noted use case in another ext before merging it in. And, yeah, this ought to go into develop.

image
image
image

@itinerare
Copy link
Collaborator

Aah, I see. Yeah that could be used for boxes pretty readily...

@Ne-wt
Copy link
Contributor Author

Ne-wt commented Aug 15, 2023

Aah, I see. Yeah that could be used for boxes pretty readily...

it'd probably need a consideration for raffles but that'd be fairly easily added (just snipe it from boxreward)

@itinerare
Copy link
Collaborator

Yeah I don't imagine that'd be too difficult to manage.

@Ne-wt
Copy link
Contributor Author

Ne-wt commented Nov 27, 2023

image
another example used in PayPal extension
image

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Nov 27, 2023
@itinerare itinerare merged commit 9eafe6a into corowne:develop Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants