-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add utility reward string creation #668
Conversation
PHP 8.1 upgrade
* hotfix: Fixing error with lowercase "auth" * hotfix: Adding "auth" fix to CommentPolicy
not implemented anywhere but allows assetArrays to be created as a reward string, using it in pets and seems like something vanilla could use to reduce code repetition
Could this possibly be used up front to replace the getBoxRewardString in BoxService? |
Yeah I'd rather either see 1. an implemented use case in core, or 2. a noted use case in another ext before merging it in. And, yeah, this ought to go into develop. |
yeah that would be the intention |
Aah, I see. Yeah that could be used for boxes pretty readily... |
it'd probably need a consideration for raffles but that'd be fairly easily added (just snipe it from boxreward) |
Yeah I don't imagine that'd be too difficult to manage. |
not implemented anywhere but allows assetArrays to be created as a reward string, using it in pets and seems like something vanilla could use to reduce code repetition