Character Items Bugfix #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidates character limit into `populateCategoryData` as it was duplicated in two different functions that use `populateCategoryData` - Fixes inability to disable category character ownership (use case: accidental enabling) --- Thoughts: Should this handle currently character-owned items?
itinerare
approved these changes
Feb 10, 2021
|
Thinking on handling currently character-owned items.... I can see a situation potentially happening where things go real weird and it being automatic is practical. But on the other hand I can also see an accidental toggle-off going really sideways with that sort of automation in place. |
|
Perhaps a standalone button + function or even a console command to remove + pass the items back to their players? One that gives plenty of warning like "This many characters have an item in this category. Are you sure? Are you really sure?" |
|
Yeah I think if anything a standalone solution would be wisest |
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populateCategoryDataas it was duplicated in two different functions that usepopulateCategoryData--- Thoughts: Should this handle currently character-owned items?
Tbh I am not sure on the usage of the tertiary and the standalone variable? But it was how it was before so I left it and used the same method for character ownership.