Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all name variables to have a maximum of 100 characters, as opposed to 25. #84

Merged
merged 1 commit into from Mar 10, 2021

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Mar 10, 2021

A lot of names for pages, posts, prompts.. all of them had a character limit of 25. I have changed this to 100, where possible. Every single changed variable has been checked if the database supported it, and they have.

Altered are:

  • News Post names
  • Sales Post names
  • Prompt names
  • Prompt Category names
  • Page names
  • Rank names
  • Species names
  • Species Subtype names
  • Shop names
  • Rarity names
  • Item Category names
  • Features names (Note: These are traits)
  • Feature Category names
  • Currency names
  • Character Category names

I have not altered the limits for abbreviations, keys, prefixes and the like, as 25 characters seems like a good maximum for short hand of the full name.
Item name limit has also not been changed as this was already at 100 characters.

The database for all of these allowed up to 191 characters, but I figured quadrupling the character amount should be more than plenty.

@itinerare itinerare added the needs review Pull requests that are pending community review label Mar 10, 2021
@Draginraptor Draginraptor merged commit 703b57e into corowne:develop Mar 10, 2021
@SpeedyD SpeedyD deleted the feature/upgrade-to-100-chars branch March 14, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull requests that are pending community review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants