-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Designs page #915
Designs page #915
Conversation
@@ -5,6 +5,7 @@ | |||
use App\Models\Character\Character; | |||
use App\Models\Character\CharacterBookmark; | |||
use App\Models\Character\CharacterImageCreator; | |||
use App\Models\Character\CharacterImage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary but should get stripped out by pint whenever it... actually acquiesces to run next...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything majorly different between the arts and designs blades? 🤔 Wondering if you could just have one blade file you use for both.
@extends('user.layout') | ||
|
||
@section('profile-title') | ||
{{ $user->name }}'s Favorites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this should say something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually pretty well in order already! Just some minor tweaks that need making.
@extends('user.layout') | ||
|
||
@section('profile-title') | ||
{{ $user->name }}'s Favorites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page title needs to be changed appropriately!
@extends('user.layout') | ||
|
||
@section('profile-title') | ||
{{ $user->name }}'s Favorites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page title again
|
||
return view('user.character_arts', [ | ||
'user' => $this->user, | ||
'designs' => $characters->get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably just be 'characters'
for ease.
|
||
return view('user.character_designs', [ | ||
'user' => $this->user, | ||
'designs' => $characters->get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise here.
@endsection | ||
|
||
@section('profile-content') | ||
{!! breadcrumbs(['Users' => 'users', $user->name => $user->url, 'Character Designs' => $user->url . '/designs']) !!} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breadcrumbs need to be updated for art page.
</h1> | ||
|
||
<div class="row"> | ||
@foreach ($designs as $character) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$designs
> $characters
if following the above comment.
</h1> | ||
|
||
<div class="row"> | ||
@foreach ($designs as $character) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$designs
> $characters
if following the above comment.
{!! breadcrumbs(['Users' => 'users', $user->name => $user->url, 'Character Designs' => $user->url . '/designs']) !!} | ||
|
||
<h1> | ||
Designs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be changed for art page.
Yeah this is probably the actual move, though minorly more complicated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resources/views/user/character_arts.blade.php
should probably be deleted since it's not being used now 🤔
I have the power! |
Hello!!! It is I, who still doesn't really know how this page works!!!
pretty much just two pages in the user sidebar- one showing all characters a user is accredited wise in terms of design, and one that shows all characters a user is accredited to in terms of masterlist art.
I don't- know what else to put here. Please have mercy on me. o/
If you saw my previous attempt, no you didn't, please spare me.