Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designs page #915

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Designs page #915

merged 3 commits into from
Apr 19, 2024

Conversation

LostInProgres
Copy link

Hello!!! It is I, who still doesn't really know how this page works!!!

pretty much just two pages in the user sidebar- one showing all characters a user is accredited wise in terms of design, and one that shows all characters a user is accredited to in terms of masterlist art.

I don't- know what else to put here. Please have mercy on me. o/

If you saw my previous attempt, no you didn't, please spare me.

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Apr 19, 2024
@@ -5,6 +5,7 @@
use App\Models\Character\Character;
use App\Models\Character\CharacterBookmark;
use App\Models\Character\CharacterImageCreator;
use App\Models\Character\CharacterImage;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary but should get stripped out by pint whenever it... actually acquiesces to run next...

Copy link
Contributor

@AW0005 AW0005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything majorly different between the arts and designs blades? 🤔 Wondering if you could just have one blade file you use for both.

@extends('user.layout')

@section('profile-title')
{{ $user->name }}'s Favorites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this should say something else

Copy link
Collaborator

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually pretty well in order already! Just some minor tweaks that need making.

@extends('user.layout')

@section('profile-title')
{{ $user->name }}'s Favorites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page title needs to be changed appropriately!

@extends('user.layout')

@section('profile-title')
{{ $user->name }}'s Favorites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page title again


return view('user.character_arts', [
'user' => $this->user,
'designs' => $characters->get(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be 'characters' for ease.


return view('user.character_designs', [
'user' => $this->user,
'designs' => $characters->get(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise here.

@endsection

@section('profile-content')
{!! breadcrumbs(['Users' => 'users', $user->name => $user->url, 'Character Designs' => $user->url . '/designs']) !!}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breadcrumbs need to be updated for art page.

</h1>

<div class="row">
@foreach ($designs as $character)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$designs > $characters if following the above comment.

</h1>

<div class="row">
@foreach ($designs as $character)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$designs > $characters if following the above comment.

{!! breadcrumbs(['Users' => 'users', $user->name => $user->url, 'Character Designs' => $user->url . '/designs']) !!}

<h1>
Designs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be changed for art page.

@itinerare
Copy link
Collaborator

Is there anything majorly different between the arts and designs blades? 🤔 Wondering if you could just have one blade file you use for both.

Yeah this is probably the actual move, though minorly more complicated.

Copy link
Contributor

@AW0005 AW0005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resources/views/user/character_arts.blade.php should probably be deleted since it's not being used now 🤔

@itinerare
Copy link
Collaborator

itinerare commented Apr 19, 2024

I have the power!

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Apr 19, 2024
@itinerare itinerare merged commit 9a76cb6 into corowne:develop Apr 19, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants