Allow central server to confirm registration #87
Conversation
Also display this state in the server UI.
| | 1 byte status | | ||
| +---------------+ | ||
|
|
||
| - "status": |
There was a problem hiding this comment.
As far as I understood, you are transmitting the enum now and not a single bit, right? Then you should update the documentation here, too.
There was a problem hiding this comment.
I will merge your changes now. Please fix this in another pull request later on.
|
Thank you for your contribution! |
|
The central server code is now updated. If you like you can test it now with the official Central Server. |
|
Looks good. The styling on the status messages makes them more obvious. The only thing is it appears to have lost the "and will re-try" after a timeout - unless that's no longer happening (which could also make sense). |
|
Are you referring to this line which I have changed? https://github.com/corrados/jamulus/blob/master/src/serverdlg.cpp#L565 I did this because the original text was too technical in my opinion. |
|
Yeah, it was a bit clumsy - I'm happy they got changed. But it lost information, too - it mentioned retries, now it doesn't. Looking at it, this one may well be wrong: |
|
Yes, but I think if it does not succeed and the error is not "server list full", something fatal does not work and the user has to do something to solve it anyway. I do not think the "retry" will give useful additional information to the user. Do you agree? |
What would you write instead? |
|
What it means is that the server response was successfully received but not understood. The retries are just the "standard ping" ones, so "retrying" is misleading, really. Basically, the slave server is too old to understand and needs to be upgraded. Dropping the "retrying" should do. |
|
done |
Also display this state in the server UI.
Rebased and retested with the latest master.