Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matcher improvements #58

Open
dominikmn opened this issue Nov 22, 2021 · 1 comment
Open

Matcher improvements #58

dominikmn opened this issue Nov 22, 2021 · 1 comment
Assignees
@dominikmn

Comments

@dominikmn
Copy link
Collaborator

dominikmn commented Nov 22, 2021 •
edited
Loading

Ich denke, wir können die Methode find_relevant_ids() entfernen:
Die Methode wird nirgendswo eingesetzt. Das Matching per get_match_for_locations() läuft ohne sie durch.
dominikmn added a commit that referenced this issue Nov 22, 2021
@dominikmn
Issue #58: Remove Matcher.find_relevant_ids()
da1ba90 
The method `find_relevant_ids()` can be deleted:
* The method `find_relevant_ids()` is not referenced anymore by any file
in the repository.
* In addition, the method faces an Error when executed as it calls the
unknown method `get_ids_by_part()`.
* Most imporant, the method `get_match_for_locations()` does run successfully without
`find_relevant_ids()`.
@pmayd
Copy link
Collaborator

pmayd commented Nov 22, 2021

weg damit wenn es nicht gebraucht wird ;)

@dominikmn dominikmn self-assigned this Nov 22, 2021
dominikmn added a commit that referenced this issue Nov 23, 2021
@dominikmn
Issue #58 Remove find_relevant_ids() in Matcher
bd98a11 
The method `find_relevant_ids()` can be deleted:
* The method `find_relevant_ids()` is not referenced anymore by any file
in the repository.
* In addition, the method faces an Error when executed as it calls the
unknown method `get_ids_by_part()`.
* Most imporant, the method `get_match_for_locations()` does run successfully without
`find_relevant_ids()`.
@dominikmn dominikmn changed the title Small improvements for Matcher Matcher improvements Nov 25, 2021
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Integrating phonetic in Matcher
1052c07 
* `find_parts_for_location()` refactoring of case `if len(parts) > 1:`
  The matched cases are from now on guaranteed to be looped exactly
  once.
* `get_best_candidates()` changed output signature.
  now:    list[str]
  before: list[tuple[str, int]]
* `find_relevant_ids()` delete this unnecessary method
* `get_loc_names()`Cosmetic improvement
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Introducing difflib
f8f2a7a 
Introduce the difflib.difflib.get_close_matches() as an
alternative to lC.search()

Introduce same control-flags for switching on/off
* Levenshtein vs difflib
* max_cost of levenshtein
* phonetic-usage
* Kreis-usage
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Extend create_synthetic_test_set()
73b81d0 
Introduce parameters
* num_parts
* distortion_factor
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Updated notebooks
d7a9b6d 
Updated the notebooks according to the changes in
synthetic.py
matcher.py
linguistic.py
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Final review with Michael
11dcd15
dominikmn added a commit that referenced this issue Nov 25, 2021
@dominikmn
Issue #58: Print anchor_method consistently
d893c18
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Integrating phonetic in Matcher
57d1d32 
* `find_parts_for_location()` refactoring of case `if len(parts) > 1:`
  The matched cases are from now on guaranteed to be looped exactly
  once.
* `get_best_candidates()` changed output signature.
  now:    list[str]
  before: list[tuple[str, int]]
* `find_relevant_ids()` delete this unnecessary method
* `get_loc_names()`Cosmetic improvement
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Introducing difflib
0cd9bc3 
Introduce the difflib.difflib.get_close_matches() as an
alternative to lC.search()

Introduce same control-flags for switching on/off
* Levenshtein vs difflib
* max_cost of levenshtein
* phonetic-usage
* Kreis-usage
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Extend create_synthetic_test_set()
39e956e 
Introduce parameters
* num_parts
* distortion_factor
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Updated notebooks
b42d2cf 
Updated the notebooks according to the changes in
synthetic.py
matcher.py
linguistic.py
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Final review with Michael
9338ab7
dominikmn added a commit that referenced this issue Jan 23, 2022
@dominikmn
Issue #58: Print anchor_method consistently
4e248b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikmn dominikmn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikmn @pmayd