Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger instead of printStackTrace() #18

Open
AzeemJiva opened this issue May 7, 2020 · 6 comments
Open

Use logger instead of printStackTrace() #18

AzeemJiva opened this issue May 7, 2020 · 6 comments
Labels
good first issue Good for newcomers minor Minor cleanup

Comments

@AzeemJiva
Copy link
Contributor

Replace all usage of printStackTrace() with a proper logging mechanism.
@AzeemJiva AzeemJiva added minor Minor cleanup good first issue Good for newcomers labels May 7, 2020
@amitvc
Copy link

amitvc commented May 25, 2020

@AzeemJiva Can I pick up this issue please?

@AzeemJiva
Copy link
Contributor Author

Yes!

@amitvc
Copy link

amitvc commented May 25, 2020

Do we want to use java.util.logging.Logger and allow users to configure log level etc or we are open to introducing something like log4j or slf4j?

@AzeemJiva
Copy link
Contributor Author

Keeping the number of dependencies down is desirable. @yoroto your thoughts?

@amitvc
Copy link

amitvc commented May 27, 2020

@AzeemJiva I agree. I can start with what is provided in jdk. We can replace it later if we need to.

@yoroto
Copy link
Contributor

yoroto commented Jul 17, 2020

@AzeemJiva Yes, we don't want to pull in those big packages, or anything would significantly affect allocation rate.

@ryota0624 ryota0624 mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers minor Minor cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yoroto @amitvc @AzeemJiva