Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: modd does not seem to shutdown deamon processes correctly when getting stopped #124

Open
Buh13246 opened this issue Jan 27, 2023 · 2 comments

Comments

@Buh13246
Copy link

I have a go-based application that needs to save internal data. The application handles signals and stops itself correctly when modd detects a change.

When I stop modd, I would expect that the application also gets a signal and shutdowns correctly. This does not seem to be the case. The application just dies without a good indication why (maybe sigkill).

modd also doesn't log that it want's to send the signal to the process.
normal behaivour:

03:54:21: daemon: ./GTAServerHomepage
>> sending signal terminated
exited: signal: terminated
>> restart backoff... 1000ms
>> starting...

On sigint:

>> starting...
^C>> stopping
➜  backend

Is this the expected behaviour or am i just doing something wrong?

@Buh13246
Copy link
Author

This is related to: #78

I could fix my issue with the provided not merged PR.

Is there any plan of fixing this issue because a sigkill should always only be the last resort.

@amery
Copy link

amery commented Apr 3, 2023

any well maintained fork available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants