Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wildcard_redirect_uri #135

Closed
toastercup opened this issue Jul 23, 2015 · 1 comment
Closed

Remove wildcard_redirect_uri #135

toastercup opened this issue Jul 23, 2015 · 1 comment
Labels
security
Milestone
Open Source

Comments

@toastercup
Copy link
Member

wildcard_redirect_uri represents a security risk, and we should instead be using the state OAuth parameter. See: doorkeeper-gem/doorkeeper@fd57c47

This precludes an upgrade to the latest Doorkeeper, as the feature has been removed as of 2.1.1.
@toastercup toastercup self-assigned this Jul 23, 2015
@toastercup toastercup added this to the Open Source milestone Jul 23, 2015
@toastercup toastercup removed their assignment Aug 13, 2015
@toastercup
Copy link
Member Author

Done & done! We've finally upgraded to Doorkeeper 3.x and can put this behind us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
Open Source
Development

No branches or pull requests
1 participant
@toastercup