-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat Query-Scheduler #268
Feat Query-Scheduler #268
Conversation
1cfb9d9
to
a89e3b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you for your contribution. Could you please do the following?
- Rebase against current master
- implement suggestions
- add ci test for query-scheduler to
test-deployment-values.yaml
or both
68ad76b
to
82a52cf
Compare
Hi @ShuzZzle. Sure, I gonna implement these changes - thanks for reviewing. |
@marquezika Need some help? :) |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
82a52cf
to
3056fa2
Compare
Hey @marquezika, Do you still wanna do this? I already rebased the branch on the current master otherwise I'm happy to finish this PR |
Signed-off-by: Joao Marques <joaomarquesq@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
3056fa2
to
07eafa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kd7lxl I think this is okay like this
might need some tests tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Yes, please add some CI values to exercise it in the tests. Then we can merge.
Signed-off-by: nschad <niclas.schad@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
What this PR does:
This MR adds the component Query-Scheduler - this makes scaling query frontend easier.
Reference: scaling-query-frontend.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]