Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Query-Scheduler #268

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Conversation

marquezika
Copy link
Contributor

What this PR does:

This MR adds the component Query-Scheduler - this makes scaling query frontend easier.

Reference: scaling-query-frontend.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@marquezika marquezika changed the title Feat/query scheduler Feat Query-Scheduler Nov 26, 2021
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for your contribution. Could you please do the following?

  • Rebase against current master
  • implement suggestions
  • add ci test for query-scheduler to test-deployment-values.yaml or both

templates/query-scheduler/query-scheduler-dep.yaml Outdated Show resolved Hide resolved
templates/query-scheduler/query-scheduler-dep.yaml Outdated Show resolved Hide resolved
templates/query-scheduler/query-scheduler-dep.yaml Outdated Show resolved Hide resolved
@marquezika
Copy link
Contributor Author

Hi @ShuzZzle.

Sure, I gonna implement these changes - thanks for reviewing.

@nschad
Copy link
Collaborator

nschad commented Dec 4, 2021

@marquezika Need some help? :)

@stale
Copy link

stale bot commented Jan 6, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2022
@nschad nschad added good first issue Good for newcomers help wanted Extra attention is needed keepalive Keeps Issue's from beeing closed labels Jan 15, 2022
@stale stale bot removed stale labels Jan 15, 2022
@nschad
Copy link
Collaborator

nschad commented Mar 3, 2022

Hey @marquezika,

Do you still wanna do this? I already rebased the branch on the current master otherwise I'm happy to finish this PR

marquezika and others added 3 commits March 14, 2022 14:44
Signed-off-by: Joao Marques <joaomarquesq@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/

Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kd7lxl I think this is okay like this

might need some tests tho

@nschad nschad requested a review from kd7lxl March 14, 2022 14:10
Copy link
Collaborator

@kd7lxl kd7lxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, please add some CI values to exercise it in the tests. Then we can merge.

Signed-off-by: nschad <niclas.schad@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
@nschad nschad merged commit f5b4a98 into cortexproject:master Mar 14, 2022
@nschad nschad mentioned this pull request May 12, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed keepalive Keeps Issue's from beeing closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants