Fix: JWT Payload validation for 2FA Strategy #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@hirenf14 is attempting to deploy a commit to the Cortip Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Instead of direct usage of UserService, it uses unified function
verifyPayloadof authService to validate JWT Payload. Also, unifies 2FA and non 2FA Authentication validation.Why is it needed?
Incorrect usage, as with verifyPayload using
payload.subit would only work for written test cases, and not when 2FA is turned off.How to test it?
Login with 2FA and without 2FA, and check whether token is validating things properly.
Related issue(s)/PR(s)
#234