Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Issue with subsequence and defaults in Avro Schema #208

Closed
2 tasks done
JonasMueller1991 opened this issue Apr 11, 2022 · 6 comments · Fixed by #209
Closed
2 tasks done

[Issue]: Issue with subsequence and defaults in Avro Schema #208

JonasMueller1991 opened this issue Apr 11, 2022 · 6 comments · Fixed by #209
Assignees
Labels
bug Something isn't working

Comments

@JonasMueller1991
Copy link

JonasMueller1991 commented Apr 11, 2022

Issue with subsequence and defaults in Avro Schema

Hey,
I found a new strange behavior in an Avro schema.
A minimal example for the Avro schema is attached.
Note that there are two fields valueWithDefaults and valueWithoutDefaults, where one of them has a default value in type. If we use this Avro schema in the Value Schema Load Generator Config and use the field type seq to send a subsequence (let's say [a,b,c]) the resulting Kafka message reads:

a -> b -> c for the case without defaults

However,

seq -> seq -> seq for the case with defaults (see in relevant log output).

I attached the minimal testplan and avro schema.

Again thanks in advance,
Jonas

.jmx and .avsc were not supported 😅
issue.avsc.txt
issue.jmx.txt

KloadGen Version

4.0.4

Relevant log output

genericRecord={"data": {"RecordArray": [{"valueWithDefaults": "seq", "valueWithoutDefaults": "a"}, {"valueWithDefaults": "seq", "valueWithoutDefaults": "b"}, {"valueWithDefaults": "seq", "valueWithoutDefaults": "c"}]}}

Have you added your JMX Testplan or a replica?

  • I have added a JMX testplan

Have you added your Schema or a replica?

  • I have added the Schema
@JonasMueller1991 JonasMueller1991 changed the title [Issue]: [Issue]: Issue with subsequence and defaults in Avro Schema Apr 11, 2022
@github-actions
Copy link

Thank you for collaborating with the project by giving us feedback!!' You will help us a lot if you can attach an example AVRO and an example Test Plan in order to be able to reproduce the error, if that is the case. Cheers

@cmunozgomez
Copy link
Contributor

Hi @JonasMueller1991

Thank you for your collaboration, we will review it and the changes/progress that we are making will inform you here.

@cmunozgomez
Copy link
Contributor

hi @JonasMueller1991,

we have detected the problem of the incorrect behavior in the cases of sequences.

We will open a pull request for the change to be integrated into the main branch. When said pull request is closed, this issue will be concluded initially.

As soon as we have the changes uploaded to the branch and the pull request created by @fcampostato , we will indicate it here.

Again thank you very much for your collaboration.

@JonasMueller1991
Copy link
Author

Thanks! :)

@fcampostato
Copy link
Contributor

Hi @JonasMueller1991,

We've being working on this today and we've uploaded a solution for this.
You can check and try it on the #208-sequence-and-defaults branch.

We are still working on it, so it can take a little to be deployed to master.
If you find any problems with the solution, please come back and we will try to help you.

Cheers!

@cmunozgomez cmunozgomez added the bug Something isn't working label Apr 13, 2022
@cmunozgomez cmunozgomez linked a pull request Apr 13, 2022 that will close this issue
cmunozgomez added a commit that referenced this issue Apr 18, 2022
@cmunozgomez
Copy link
Contributor

hi @JonasMueller1991,

the pull request associated with this issue was integrated into the main branch, therefore this issue is closed.

Again, thank you very much for your collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants