-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams resetting resource version #231
Comments
Oooh you're probably right, it seems in this case we should not reset the RV. Still, can you give me some more details on what you're doing? So you're watching pods and you get these as a pod is starting up? As for the log spam
|
Ooooh you're watching Events, right? Ha! Thats some nice edge case. The implementation is wrong of course. |
Among other things yea. We start watching streams for ~80 different resource kinds (some that are on the cluster as crds and some that aren't). Essentially we are streaming everything that is happening on the clusters. Event is the most interesting. |
I didn't mean to imply there is anything wrong with the amount that k8s is logging. I think it's totally fine. I actually prefer a noisy log with extra info. We just run with just about all logging turned on so I consider the whole logging stream as a firehose, and that verbiage slipped in. |
We have a k8s application that streams a watch of just about every kind or resource. When there's a lot of activity we will see a lot of log spam like this:
https://github.com/coryodaniel/k8s/blob/develop/lib/k8s/client/runner/stream/watch.ex#L170 It seems like watches are resetting the version when they should just ignore that event line.
The text was updated successfully, but these errors were encountered: