Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gregorian calendar hard-coded in datetime-fortran #37

Open
aekiss opened this issue Jan 16, 2020 · 2 comments
Open

Gregorian calendar hard-coded in datetime-fortran #37

aekiss opened this issue Jan 16, 2020 · 2 comments

Comments

@aekiss
Copy link
Contributor

aekiss commented Jan 16, 2020

I just noticed that the Gregorian definition of leap years is hard-coded in datetime-fortran:
https://github.com/wavebitscientific/datetime-fortran/blob/master/src/lib/mod_datetime.f90#L1053

I guess this would prohibit the use of different calendars (e.g. noleap) - could this cause any problems, e.g. with RYF?

Note that this also means a proleptic Gregorian calendar is applied prior to the year 1582 (see COSIMA/access-om2#117).

@aidanheerdegen
Copy link
Contributor

That library doesn't seem to support any calendar type but iso variant of gregorian

https://github.com/wavebitscientific/datetime-fortran/blob/335cf9a495ba7df43e14c6a793523fd180b1b345/README.md#isocalendar

Darn.

@nichannah
Copy link
Contributor

I think that this library is intended to have similar functionality to the Python module of the same name. I think it is difficult to find date handling libraries that support different calendar types.

libaccessom2 does a workaround to support noleap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants