Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4 Feedback #20

Closed
jonathanmeier5 opened this issue May 20, 2019 · 1 comment
Closed

Chapter 4 Feedback #20

jonathanmeier5 opened this issue May 20, 2019 · 1 comment

Comments

@jonathanmeier5
Copy link

Chapter 4 Feedback:

Great introduction to the Unit of Work pattern. Very punchy, gets points across well.

Handful of comments:


I particularly appreciated the discussion on "Explicit vs implicit commits", as it addressed a lingering question I had from Chapter 2 regarding why you were calling commit from outside the Repository class.


I had to google the nullcontext built in - very neat!


In Example 8. Reallocate service function
uow has a products attribute. I can't seem to find where this came into our model or when we created a repository class for it (I assume it points to a ProductRepository class).

@hjwp hjwp closed this as completed in 379bc18 May 20, 2019
@hjwp
Copy link
Contributor

hjwp commented May 20, 2019

thanks for these too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants