feat: add timepb support library #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
amaury1093,
fdymylja and
technicallyty
|
Let's decide about |
19 tasks
aaronc
reviewed
Feb 3, 2022
|
@aaronc so maybe we should remove the |
|
I've added rapid tests |
technicallyty
approved these changes
Feb 8, 2022
This was referenced Feb 8, 2022
I'd say let's drop |
aaronc
reviewed
Feb 8, 2022
| @@ -0,0 +1,3 @@ | |||
| # timepb | |||
There was a problem hiding this comment.
Should this be a README or docs.go? Not sure what is best practice. I think the advantage of docs.go is that it shows up in pkg.go.dev like this for sub-packages:
There was a problem hiding this comment.
README shows up in pkg.go.dev as well when you go to the package page. I think we need both. Will add doc.go
aaronc
reviewed
Feb 8, 2022
aaronc
approved these changes
Feb 8, 2022
technicallyty
approved these changes
Feb 8, 2022
Co-authored-by: Aaron Craelius <aaron@regen.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved from: cosmos/cosmos-sdk#11085
A support library to do time operation with protobuf Timestamp
Motivation
With new proto directions we are going away from go stdlib
time.Timeto the protobuf Timestamppb package.We often do time operations (eg comparing times) and we need a canonical library for Timestamppb rather then repeating / copying code.
Updates
types/wellknown/time. We are not creating a new types, but a support library, so I propose here different path:support/timepbpbtime, but it seams in protobuf they prefer to addpbas a suffix.