Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authz expire to make it optional #11095

Closed
4 tasks
Tracked by #11096
robert-zaremba opened this issue Feb 2, 2022 · 5 comments · Fixed by #11060
Closed
4 tasks
Tracked by #11096

Update authz expire to make it optional #11095

robert-zaremba opened this issue Feb 2, 2022 · 5 comments · Fixed by #11060
Assignees

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Feb 2, 2022

Summary

Today, autz expire is not optional, against it's design.

Proposal

  1. Remove nullable = false in
    // Grant gives permissions to execute
    // the provide method with expiration time.
    message Grant {
    google.protobuf.Any authorization = 1 [(cosmos_proto.accepts_interface) = "Authorization"];
    google.protobuf.Timestamp expiration = 2 [(gogoproto.stdtime) = true, (gogoproto.nullable) = false];
    }
  2. Don't add to the expiration queue if there's no expiration date (depends on feat(authz)!: pruning expired authorizations #10714)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba self-assigned this Feb 2, 2022
This was referenced Feb 2, 2022
@likhita-809
Copy link
Contributor

@robert-zaremba did you start working on this ?
If not, I can do so.

@amaury1093
Copy link
Contributor

This issue actually depends on #10714.

I'm wondering if we can do it all at once in one PR. What do you think @aleem1314 ?

@aleem1314
Copy link
Contributor

I'm wondering if we can do it all at once in one PR. What do you think @aleem1314 ?

I think @robert-zaremba working on this. There is a draft PR 11060.

@robert-zaremba
Copy link
Collaborator Author

Yes, let's firstly merge #10714

@robert-zaremba
Copy link
Collaborator Author

This one also depends on: cosmos/cosmos-proto#60 , so please review

@robert-zaremba robert-zaremba added this to the v0.46 milestone Feb 24, 2022
@mergify mergify bot closed this as completed in #11060 Mar 24, 2022
mergify bot pushed a commit that referenced this issue Mar 24, 2022
## Description

Closes: #11095 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants