-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM support with grpc-web #88
Conversation
We already support WASM and test it in CI: https://github.com/cosmos/cosmos-rust/blob/main/.github/workflows/cosmos-sdk-proto.yml#L20-L38 Perhaps we need to better document it. To support WASM, add [dependencies.cosmos-sdk-proto]
version = "0.5"
default-features = false |
Yes but this will disable grpc, this pr is to support grpc-web - which requires tonic Edit: Renamed misleading heading |
People can use https://github.com/titanous/grpc-web-client along with this to support grpc-web in wasm. Eventually tonic will have this builtin in some way which is tracked in this issue hyperium/tonic#645 |
Aha! In that case, can you remove the It's a breaking change, but tendermint-rs v0.20 is about to be released and that's a breaking change as well. |
@shravanshetty1 mind rebasing? |
…patible since transport related generated code has been removed
…patible since transport related generated code has been removed
Regenerated files by disabling the "transport" feature in tonic, this will allow "cosmos-sdk-proto" to be imported into wasm based applications.