replace testutil.NewTestCaseDir() with Go1.15's T.TempDir() (#7014)

Override go's default version with go 1.15.

.github/workflows/sims.yml

@@ -21,17 +21,24 @@ jobs:
     if: "!contains(github.event.head_commit.message, 'skip-sims')"
     steps:
       - uses: actions/checkout@v2
-      - run: |
-          make build
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
+      - run: make build
 
   install-runsim:
     runs-on: ubuntu-latest
     needs: build
     steps:
       - uses: actions/setup-go@v2.1.2
-      - name: install runsim
-        run: |
-          export GO111MODULE="on" && go get github.com/cosmos/tools/cmd/runsim@v1.0.0
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
+      - name: Install runsim
+        run: export GO111MODULE="on" && go get github.com/cosmos/tools/cmd/runsim@v1.0.0
       - uses: actions/cache@v2.1.1
         with:
           path: ~/go/bin
@@ -42,6 +49,11 @@ jobs:
     needs: [build, install-runsim]
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         with:
           SUFFIX_FILTER: |
@@ -65,6 +77,11 @@ jobs:
     needs: [build, install-runsim]
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         with:
           SUFFIX_FILTER: |
@@ -88,6 +105,11 @@ jobs:
     needs: [build, install-runsim]
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         with:
           SUFFIX_FILTER: |
@@ -111,6 +133,11 @@ jobs:
     needs: [build, install-runsim]
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         with:
           SUFFIX_FILTER: |

.github/workflows/tag.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2.1.2
         with:
-          go-version: 1.14
+          go-version: 1.15
       - name: Unshallow
         run: git fetch --prune --unshallow
       - name: Create release

.github/workflows/test.yml

@@ -19,6 +19,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - name: install tparse
         run: |
           export GO111MODULE="on" && go get github.com/mfridman/tparse@v0.8.3
@@ -31,6 +35,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v1
         id: git_diff
         with:
@@ -48,6 +57,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - name: Create a file with all the pkgs
         run: go list ./... > pkgs.txt
       - name: Split pkgs into 4 files
@@ -76,6 +90,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -113,6 +132,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -150,6 +174,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -187,6 +216,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -224,6 +258,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -249,6 +288,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -274,6 +318,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:
@@ -299,6 +348,11 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2.1.2
+        with:
+          go-version: 1.15
+      - name: Display go version
+        run: go version
       - uses: technote-space/get-diff-action@v3
         id: git_diff
         with:

README.md

@@ -49,7 +49,7 @@ It is being used to build [`Gaia`](https://github.com/cosmos/gaia), the first im
 **WARNING**: The SDK has mostly stabilized, but we are still making some
 breaking changes.
 
-**Note**: Requires [Go 1.14+](https://golang.org/dl/)
+**Note**: Requires [Go 1.15+](https://golang.org/dl/)
 
 ## Quick Start
 

client/keys/add_ledger_test.go

@@ -37,9 +37,7 @@ func Test_runAddCmdLedgerWithCustomCoinType(t *testing.T) {
 	cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
 
 	// Prepare a keybase
-	kbHome, kbCleanUp := testutil.NewTestCaseDir(t)
-	require.NotNil(t, kbHome)
-	t.Cleanup(kbCleanUp)
+	kbHome := t.TempDir()
 
 	cmd.SetArgs([]string{
 		"keyname1",
@@ -86,11 +84,7 @@ func Test_runAddCmdLedger(t *testing.T) {
 	cmd := AddKeyCommand()
 	cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
-
-	// Prepare a keybase
-	kbHome, kbCleanUp := testutil.NewTestCaseDir(t)
-	require.NotNil(t, kbHome)
-	t.Cleanup(kbCleanUp)
+	kbHome := t.TempDir()
 
 	cmd.SetArgs([]string{
 		"keyname1",

client/keys/add_test.go

@@ -20,12 +20,9 @@ func Test_runAddCmdBasic(t *testing.T) {
 	cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
 
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
-
-	kbHome, kbCleanUp := testutil.NewTestCaseDir(t)
-	require.NotNil(t, kbHome)
-	t.Cleanup(kbCleanUp)
-
+	kbHome := t.TempDir()
 	kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn)
+
 	require.NoError(t, err)
 	t.Cleanup(func() {
 		_ = kb.Delete("keyname1")

client/keys/delete_test.go

@@ -15,9 +15,7 @@ import (
 
 func Test_runDeleteCmd(t *testing.T) {
 	// Now add a temporary keybase
-	kbHome, cleanUp := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp)
-
+	kbHome := t.TempDir()
 	cmd := DeleteKeyCommand()
 	cmd.Flags().AddFlagSet(Commands(kbHome).PersistentFlags())
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)

client/keys/export_test.go

@@ -20,8 +20,7 @@ func Test_runExportCmd(t *testing.T) {
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
 
 	// Now add a temporary keybase
-	kbHome, cleanUp := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp)
+	kbHome := t.TempDir()
 
 	// create a key
 	kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn)

client/keys/import_test.go

@@ -20,10 +20,9 @@ func Test_runImportCmd(t *testing.T) {
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
 
 	// Now add a temporary keybase
-	kbHome, cleanUp := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp)
-
+	kbHome := t.TempDir()
 	kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn)
+
 	require.NoError(t, err)
 	t.Cleanup(func() {
 		kb.Delete("keyname1") // nolint:errcheck

client/keys/list_test.go

@@ -18,11 +18,8 @@ func Test_runListCmd(t *testing.T) {
 	cmd := ListKeysCmd()
 	cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
 
-	kbHome1, cleanUp1 := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp1)
-
-	kbHome2, cleanUp2 := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp2)
+	kbHome1 := t.TempDir()
+	kbHome2 := t.TempDir()
 
 	mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
 	kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome2, mockIn)

client/keys/migrate_test.go

@@ -18,11 +18,9 @@ func Test_runMigrateCmd(t *testing.T) {
 	_ = testutil.ApplyMockIODiscardOutErr(cmd)
 	cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
 
-	kbHome, kbCleanUp := testutil.NewTestCaseDir(t)
-	copy.Copy("testdata", kbHome)
-	assert.NotNil(t, kbHome)
-	t.Cleanup(kbCleanUp)
+	kbHome := t.TempDir()
 
+	copy.Copy("testdata", kbHome)
 	cmd.SetArgs([]string{
 		"keyname1",
 		fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),

client/keys/show_test.go

@@ -49,9 +49,7 @@ func Test_runShowCmd(t *testing.T) {
 	cmd.SetArgs([]string{"invalid1", "invalid2"})
 	require.EqualError(t, cmd.Execute(), "invalid1 is not a valid name or address: decoding bech32 failed: invalid index of 1")
 
-	kbHome, cleanUp := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanUp)
-
+	kbHome := t.TempDir()
 	fakeKeyName1 := "runShowCmd_Key1"
 	fakeKeyName2 := "runShowCmd_Key2"
 

client/tx/tx_test.go

@@ -12,7 +12,6 @@ import (
 	"github.com/cosmos/cosmos-sdk/crypto/hd"
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
 	"github.com/cosmos/cosmos-sdk/simapp"
-	"github.com/cosmos/cosmos-sdk/testutil"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/x/auth/signing"
 	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
@@ -122,11 +121,8 @@ func TestBuildUnsignedTx(t *testing.T) {
 }
 
 func TestSign(t *testing.T) {
-	dir, clean := testutil.NewTestCaseDir(t)
-	t.Cleanup(clean)
-
 	path := hd.CreateHDPath(118, 0, 0).String()
-	kr, err := keyring.New(t.Name(), "test", dir, nil)
+	kr, err := keyring.New(t.Name(), "test", t.TempDir(), nil)
 	require.NoError(t, err)
 
 	var from = "test_sign"

crypto/keyring/keyring_ledger_test.go

@@ -9,7 +9,6 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/cosmos/cosmos-sdk/crypto/hd"
-	"github.com/cosmos/cosmos-sdk/testutil"
 	"github.com/cosmos/cosmos-sdk/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
@@ -52,8 +51,8 @@ func TestInMemoryCreateLedger(t *testing.T) {
 // TestSignVerify does some detailed checks on how we sign and validate
 // signatures
 func TestSignVerifyKeyRingWithLedger(t *testing.T) {
-	dir, cleanup := testutil.NewTestCaseDir(t)
-	t.Cleanup(cleanup)
+	dir := t.TempDir()
+
 	kb, err := New("keybasename", "test", dir, nil)
 	require.NoError(t, err)
 
@@ -89,8 +88,7 @@ func TestSignVerifyKeyRingWithLedger(t *testing.T) {
 }
 
 func TestAltKeyring_SaveLedgerKey(t *testing.T) {
-	dir, clean := testutil.NewTestCaseDir(t)
-	t.Cleanup(clean)
+	dir := t.TempDir()
 
 	keyring, err := New(t.Name(), BackendTest, dir, nil)
 	require.NoError(t, err)