Skip to content

Commit

Permalink
fix: runtime: fix (*App).RegisterMoodules inconsistency in checking/m…
Browse files Browse the repository at this point in the history
…emoizing appModule (#14128) (#14129)
  • Loading branch information
mergify[bot] committed Dec 2, 2022
1 parent 7888f0a commit 932e08c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtime/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ func (a *App) RegisterModules(modules ...module.AppModule) error {
if _, ok := a.ModuleManager.Modules[name]; ok {
return fmt.Errorf("AppModule named %q already exists", name)
}
a.ModuleManager.Modules[name] = appModule

if _, ok := a.basicManager[name]; ok {
return fmt.Errorf("AppModuleBasic named %q already exists", name)
}

a.ModuleManager.Modules[name] = appModule
a.basicManager[name] = appModule
appModule.RegisterInterfaces(a.interfaceRegistry)
appModule.RegisterLegacyAminoCodec(a.amino)
Expand Down

0 comments on commit 932e08c

Please sign in to comment.