Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited 0.45 Cosmos SDK release #10656

Closed
8 of 12 tasks
robert-zaremba opened this issue Dec 1, 2021 · 17 comments
Closed
8 of 12 tasks

Limited 0.45 Cosmos SDK release #10656

robert-zaremba opened this issue Dec 1, 2021 · 17 comments
Milestone

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Dec 1, 2021

Summary

There is a need in the community to release v0.45 sooner. The idea is to not add any significant effort nor any changes which could create any risk.

Also, we would need to think if with v0.45 release will stop support for 0.42 (which will sunshine anyway at the end of January 2022) and how long to support 0.44.

Here is an "in progress" list of what we an merge into potential 0.45.

Included:

Maybe:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v0.45 milestone Dec 1, 2021
@ethanfrey
Copy link
Contributor

Those first two gas related ones are critical for a wasmd 1.o release we can safely stand behind reliability wise.

We are targeting a early January release date and starting the 0.42 to 0.44 migration shortly (the last step left)

Many chains have been asking for this and going ahead on untested versions, and we would be very happy to have those first two gas related prs in an official Cosmos sdk release we can depend on.

I am happy for any other minor changes as well, but please no larger breaking ones

@amaury1093
Copy link
Contributor

amaury1093 commented Dec 2, 2021

Let's remove #10348 :

  • it needs a joint effort with the Ledger team to update the Ledger cosmos app, we talked with Juan, and we're planning to do that along with the next major release (so 0.46) with the tip feature (which also needs Ledger update)
  • that PR 10348 adds support for tips + feepayer in Amino. There's some non-trivial cherry-picking if we only want to backport feepayer, plus some non-trivial QA.

@amaury1093
Copy link
Contributor

Current timeline is to release on Tues 14th.

@ethanfrey
Copy link
Contributor

Thank you very much!

@amaury1093
Copy link
Contributor

Due to some critical bugs discovered recently, we decided to release 0.45 early January.

@fedekunze
Copy link
Collaborator

fedekunze commented Dec 28, 2021

@ethanfrey
Copy link
Contributor

So the only real blocker here is merging #10770 right?

I see #10281 which is important but don't see a pr for it on master

@robert-zaremba
Copy link
Collaborator Author

#10281 can come in a patch release.

@fedekunze
Copy link
Collaborator

are there any blockers now? I think we are ready with all the issues based on this list and the milestone?

@robert-zaremba @AmauryM @aaronc @marbar3778

@robert-zaremba
Copy link
Collaborator Author

@fedekunze we are testing the upgrade. Yesterday, @AmauryM made a test and it failed. If you have available cycles, could you also make an upgrade test on your side?

@robert-zaremba
Copy link
Collaborator Author

our qa-team did another test this morning and it worked, so we are trying to replicate.

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 13, 2022

My localnet repro is:

  • on a v044 chain, create a proposal "abc" at height 50
  • make some votes for it to pass
  • wait for the node to panic at height 50
  • ./build/simd start using the v045 node

At startup of the new node, I get:

3:15PM INF applying upgrade "abc" at height: 50
3:15PM ERR WARNING: Attempt to allocate proposer rewards to unknown proposer cosmosvalcons1ha3pfjev0q0e3j7k7yum0mu7catx28rh4hutfd. This should happen only if the proposer unbonded completely within a single block, which generally should not happen except in exceptional circumstances (or fuzz testing). We recommend you investigate immediately. module=x/distribution
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x4ee02b1]

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/distribution/keeper.Keeper.AllocateTokensToValidator({{0x5857970, 0xc0010966a0}, {0x950a6d0, 0xc001097450}, {{0x950a6d0, 0xc001097450}, 0xc000c0cd18, {0x5857970, 0xc0010966d0}, {0x58579c0, ...}, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk/x/distribution/keeper/allocation.go:107 +0x51
github.com/cosmos/cosmos-sdk/x/distribution/keeper.Keeper.AllocateTokens({{0x5857970, 0xc0010966a0}, {0x950a6d0, 0xc001097450}, {{0x950a6d0, 0xc001097450}, 0xc000c0cd18, {0x5857970, 0xc0010966d0}, {0x58579c0, ...}, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk/x/distribution/keeper/allocation.go:95 +0x1111

Maybe I messed up something though

@amaury1093
Copy link
Contributor

Since the qa team managed a successful v044->v045 upgrade, I just tagged a v0.45.0-rc1.

If you have available cycles, could you also make an upgrade test on your side?

echoing this, cc @ethanfrey and @ValarDragon too

@ethanfrey
Copy link
Contributor

awesome work. thanks!

@tac0turtle tac0turtle modified the milestones: v0.46, v0.45.0 Jan 13, 2022
@tac0turtle
Copy link
Member

closing as 0.45 is released

@ethanfrey
Copy link
Contributor

Just released wasmd 0.22 using Cosmos SDK 0.45.0
Launching testnet tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants