fix: enable setting sequence (nonce) for module account #10536

fedekunze · 2021-11-14T14:14:58Z

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct docs: prefix in the PR title
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
followed the documentation writing guidelines
reviewed "Files changed" and left comments if necessary
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct docs: prefix in the PR title
confirmed all author checklist items have been addressed
confirmed that this PR only changes documentation
reviewed content for consistency
reviewed content for thoroughness
reviewed content for spelling and grammar
tested instructions (if applicable)

alexanderbez

Why does an account that does not need replay protection, as it never it never has txs that are sent from it, need nonce management?

fedekunze · 2021-11-15T07:49:59Z

@alexanderbez we need to use the nonce to create new contracts that are owned by the module address. Contract addresses are composed by the owner address + nonce.

See #10538

tac0turtle · 2021-11-15T13:45:12Z

x/auth/types/account.go

@@ -218,11 +218,6 @@ func (ma ModuleAccount) SetPubKey(pubKey cryptotypes.PubKey) error {
 	return fmt.Errorf("not supported for module accounts")
 }

-// SetSequence - Implements AccountI
-func (ma ModuleAccount) SetSequence(seq uint64) error {


why was this like this in the first place? @AmauryM @robert-zaremba do you know?

afaik because the account didn't need replay protection

I don't know. We don't check sequence number for module accounts. It seams it was added to make the ModuleAccount compatible / implementing the auth/types.AccountI interface

This is an old code. It seams it was originally implemented by @fedekunze ;) in x/supply and then moved here.

3526784

tac0turtle

utACK. Before merge it would be good to know why this was present

…/cosmos-sdk into fedekunze/module-account-sequence

alexanderbez

I don't see any harm in having this functionality. utACK

## Description Closes cosmos#10538 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct `docs:` prefix in the PR title - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md) - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct `docs:` prefix in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] confirmed that this PR only changes documentation - [ ] reviewed content for consistency - [ ] reviewed content for thoroughness - [ ] reviewed content for spelling and grammar - [ ] tested instructions (if applicable)

tac0turtle · 2021-12-28T10:55:00Z

@Mergifyio backport release/0.45.x

mergify · 2021-12-28T10:55:33Z

backport release/0.45.x

❌ No backport have been created

Backport to branch release/0.45.x failed: Branch not found

tac0turtle · 2021-12-28T10:55:52Z

@Mergifyio backport release/v0.45.x

## Description Closes #10538 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct `docs:` prefix in the PR title - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md) - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct `docs:` prefix in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] confirmed that this PR only changes documentation - [ ] reviewed content for consistency - [ ] reviewed content for thoroughness - [ ] reviewed content for spelling and grammar - [ ] tested instructions (if applicable) (cherry picked from commit 7043dde) # Conflicts: # CHANGELOG.md

mergify · 2021-12-28T10:56:36Z

backport release/v0.45.x

✅ Backports have been created

#10846 fix: enable setting sequence (nonce) for module account (backport #10536) has been created for branch release/v0.45.x

) (#10846) * fix: enable setting sequence (nonce) for module account (#10536) ## Description Closes #10538 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct `docs:` prefix in the PR title - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md) - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct `docs:` prefix in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] confirmed that this PR only changes documentation - [ ] reviewed content for consistency - [ ] reviewed content for thoroughness - [ ] reviewed content for spelling and grammar - [ ] tested instructions (if applicable) (cherry picked from commit 7043dde) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

…mos#10536) (cosmos#10846) * fix: enable setting sequence (nonce) for module account (cosmos#10536) ## Description Closes cosmos#10538 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct `docs:` prefix in the PR title - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md) - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct `docs:` prefix in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] confirmed that this PR only changes documentation - [ ] reviewed content for consistency - [ ] reviewed content for thoroughness - [ ] reviewed content for spelling and grammar - [ ] tested instructions (if applicable) (cherry picked from commit 7043dde) # Conflicts: # CHANGELOG.md * conflicts Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

fix: enable setting sequence (nonce) for module account

857a345

github-actions bot added the C:x/auth label Nov 14, 2021

changelog

3b05bcc

fedekunze marked this pull request as ready for review November 14, 2021 14:17

fedekunze requested review from aaronc and alexanderbez as code owners November 14, 2021 14:17

Merge branch 'master' into fedekunze/module-account-sequence

d9085da

fedekunze requested review from amaury1093, blushi and tac0turtle November 14, 2021 14:34

fedekunze self-assigned this Nov 14, 2021

alexanderbez reviewed Nov 15, 2021

View reviewed changes

Merge branch 'master' into fedekunze/module-account-sequence

4105100

fedekunze added A:automerge Automatically merge PR once all prerequisites pass. T:Bug labels Nov 15, 2021

fedekunze requested a review from robert-zaremba November 15, 2021 11:45

fedekunze added 2 commits November 15, 2021 12:45

Merge branch 'master' into fedekunze/module-account-sequence

9126065

Merge branch 'master' into fedekunze/module-account-sequence

e7ebd0e

tac0turtle reviewed Nov 15, 2021

View reviewed changes

tac0turtle approved these changes Nov 15, 2021

View reviewed changes

fedekunze and others added 3 commits November 15, 2021 15:17

changelog

3ddc7c8

Merge branch 'fedekunze/module-account-sequence' of github.com:cosmos…

3a8dd00

…/cosmos-sdk into fedekunze/module-account-sequence

Merge branch 'master' into fedekunze/module-account-sequence

a80789c

alexanderbez approved these changes Nov 15, 2021

View reviewed changes

mergify bot merged commit 7043dde into master Nov 15, 2021

mergify bot deleted the fedekunze/module-account-sequence branch November 15, 2021 15:52

adamansky added a commit to aiax-network/cosmos-sdk that referenced this pull request Dec 10, 2021

* Applied cosmos#10536 to v0.44.5

e7767f8

fedekunze mentioned this pull request Dec 28, 2021

Limited 0.45 Cosmos SDK release #10656

Closed

12 tasks

mergify bot mentioned this pull request Dec 28, 2021

fix: enable setting sequence (nonce) for module account (backport #10536) #10846

Merged

faddat mentioned this pull request Feb 28, 2022

v0.45.x akash-network/cosmos-sdk#176

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: enable setting sequence (nonce) for module account #10536

fix: enable setting sequence (nonce) for module account #10536

fedekunze commented Nov 14, 2021 •

edited

Loading

alexanderbez left a comment

fedekunze commented Nov 15, 2021

tac0turtle Nov 15, 2021

fedekunze Nov 15, 2021

robert-zaremba Nov 15, 2021

robert-zaremba Nov 15, 2021 •

edited

Loading

tac0turtle left a comment

alexanderbez left a comment

tac0turtle commented Dec 28, 2021

mergify bot commented Dec 28, 2021

tac0turtle commented Dec 28, 2021

mergify bot commented Dec 28, 2021

fix: enable setting sequence (nonce) for module account #10536

fix: enable setting sequence (nonce) for module account #10536

Conversation

fedekunze commented Nov 14, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

alexanderbez left a comment

Choose a reason for hiding this comment

fedekunze commented Nov 15, 2021

tac0turtle Nov 15, 2021

Choose a reason for hiding this comment

fedekunze Nov 15, 2021

Choose a reason for hiding this comment

robert-zaremba Nov 15, 2021

Choose a reason for hiding this comment

robert-zaremba Nov 15, 2021 • edited Loading

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

tac0turtle commented Dec 28, 2021

mergify bot commented Dec 28, 2021

❌ No backport have been created

tac0turtle commented Dec 28, 2021

mergify bot commented Dec 28, 2021

✅ Backports have been created

fedekunze commented Nov 14, 2021 •

edited

Loading

robert-zaremba Nov 15, 2021 •

edited

Loading