Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor x/gov to use mocks #12752

Closed
2 tasks done
amaury1093 opened this issue Jul 27, 2022 · 1 comment · Fixed by #13043
Closed
2 tasks done

Refactor x/gov to use mocks #12752

amaury1093 opened this issue Jul 27, 2022 · 1 comment · Fixed by #13043
Assignees
@amaury1093

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jul 27, 2022 •
edited by tac0turtle

Part of #12398
@amaury1093 amaury1093 self-assigned this Jul 27, 2022
@amaury1093 amaury1093 mentioned this issue Jul 27, 2022
Closed
27 tasks
@julienrbrt
Copy link
Member

We should not forget to do this in this issue too: #12398 (comment)

This was referenced Aug 22, 2022
Merged
Merged
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@amaury1093
test(gov): Refactor x/gov keeper tests to use mocks (#12988)
fc7ee0b 
## Description

ref: #12752 

- [x] Move some keeper tests into `tests/integration/gov/keeper`, see #12988 (comment)
- [x] Don't use simapp in `x/gov/keeper` tests, use mocks instead
- [x] Find 0 "simapp" occurence in x/gov/keeper. (Note: other occurrences of simapp are removed in  #13043)



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Eengineer1 added a commit to cheqd/cosmos-sdk that referenced this issue Aug 26, 2022
@Eengineer1
Squashed commit of the following:
4e6d191 
commit d11196a
Author: Robert Zaremba <robert@zaremba.ch>
Date:   Fri Aug 26 20:05:39 2022 +0200

    deps: bump gin-gonic (cosmos#13061)

    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit 20b947e
Author: Daniel Wedul <github@wedul.com>
Date:   Fri Aug 26 11:29:58 2022 -0600

    fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (cosmos#13051)

    * [13030]: When a legacy gov proposal fails it's handler check, wrap the error in a ErrInvalidProposalContent (instead of ErrNoProposalHandlerExists).

    * [13030]: Add changelog entry.

    * [13030]: If the error is already a ErrNoProposalHandlerExists, just return it. Otherwise, wrap it as a ErrInvalidProposalContent.

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

commit fc7ee0b
Author: Amaury <1293565+amaurym@users.noreply.github.com>
Date:   Thu Aug 25 22:15:44 2022 +0200

    test(gov): Refactor x/gov keeper tests to use mocks (cosmos#12988)

    ## Description

    ref: cosmos#12752

    - [x] Move some keeper tests into `tests/integration/gov/keeper`, see cosmos#12988 (comment)
    - [x] Don't use simapp in `x/gov/keeper` tests, use mocks instead
    - [x] Find 0 "simapp" occurence in x/gov/keeper. (Note: other occurrences of simapp are removed in  cosmos#13043)

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

commit 1fb6f0b
Author: Daniel Wedul <github@wedul.com>
Date:   Thu Aug 25 13:43:40 2022 -0600

    feat(x/auth): Add auth sim decoder case for AccountNumberStoreKeyPrefix (cosmos#13048)

    * [13028]: Add auth sim decoder case for AccountNumberStoreKeyPrefix (and a unit test case for it).

    * [13028]: Add changelog entry.

commit 5e4651e
Author: Daniel Wedul <github@wedul.com>
Date:   Thu Aug 25 13:17:46 2022 -0600

    feat(x/authz): Add the GetAuthorization function. (cosmos#13047)

    * [13027]: Create the GetAuthorization function (in the authz module).

    * [13027]: Add unit tests for the new GetAuthorization function.

    * [13027]: Add changelog entry.

commit c73171f
Author: Julien Robert <julien@rbrt.fr>
Date:   Thu Aug 25 17:54:50 2022 +0200

    fix: missing return statement in BaseApp.Query (cosmos#13046)

    ## Description

    Closes: cosmos#13040

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

commit e1999e4
Author: JayT106 <JayT106@users.noreply.github.com>
Date:   Thu Aug 25 17:09:52 2022 +0800

    fix: exporting the blockParams regression (cosmos#13029)

    ## Description

    Closes: cosmos#13024

    ---

    ### Author Checklist

    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*

    I have...

    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [x] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [x] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [x] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed

    ### Reviewers Checklist

    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*

    I have...

    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)

commit 6af89d6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 23:13:11 2022 +0200

    build(deps): Bump github.com/golangci/golangci-lint from 1.48.0 to 1.49.0 (cosmos#13013)

    * build(deps): Bump github.com/golangci/golangci-lint

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.48.0 to 1.49.0.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.48.0...v1.49.0)

    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    * updates

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Julien Robert <julien@rbrt.fr>

commit d8a7dbd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 21:47:14 2022 +0200

    build(deps): Bump google.golang.org/grpc in /client/v2 (cosmos#13021)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0.
    - [Release notes](https://github.com/grpc/grpc-go/releases)
    - [Commits](grpc/grpc-go@v1.48.0...v1.49.0)

    ---
    updated-dependencies:
    - dependency-name: google.golang.org/grpc
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4fbd246
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 21:31:50 2022 +0200

    build(deps): Bump github.com/cosmos/cosmos-sdk in /store/tools/ics23 (cosmos#13020)

    Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.46.0 to 0.46.1.
    - [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
    - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.46.1/CHANGELOG.md)
    - [Commits](cosmos/cosmos-sdk@v0.46.0...v0.46.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/cosmos/cosmos-sdk
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 55307d6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 21:02:14 2022 +0200

    build(deps): Bump google.golang.org/grpc in /errors (cosmos#13017)

commit 4d2fc82
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 20:48:36 2022 +0200

    build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 in /orm (cosmos#13016)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0.
    - [Release notes](https://github.com/grpc/grpc-go/releases)
    - [Commits](grpc/grpc-go@v1.48.0...v1.49.0)

    ---
    updated-dependencies:
    - dependency-name: google.golang.org/grpc
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0a5647e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 19:23:13 2022 +0200

    build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 in /api (cosmos#13015)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0.
    - [Release notes](https://github.com/grpc/grpc-go/releases)
    - [Commits](grpc/grpc-go@v1.48.0...v1.49.0)

    ---
    updated-dependencies:
    - dependency-name: google.golang.org/grpc
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 149787b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 24 18:27:37 2022 +0200

    build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 (cosmos#13014)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0.
    - [Release notes](https://github.com/grpc/grpc-go/releases)
    - [Commits](grpc/grpc-go@v1.48.0...v1.49.0)

    ---
    updated-dependencies:
    - dependency-name: google.golang.org/grpc
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mergify mergify bot closed this as completed in #13043 Aug 29, 2022
mergify bot pushed a commit that referenced this issue Aug 29, 2022
@amaury1093
test(gov): Remove simapp references from module tests and simulatio…
7b74671 
…ns (#13043)

## Description

0 occurences of "simapp" in x/gov.

closes: #12752

- [x] Move some x/gov module tests (those in x/gov root folder) to tests/integration, as they rely on a new module x/distribution
- [x] convert rest of x/gov module tests to use depinject
- [x] remove simapp references from x/gov/simulations
- [x] 0 occurences of "simapp" in x/gov



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this issue Oct 26, 2022
@amaury1093 @Wryhder
test(gov): Refactor x/gov keeper tests to use mocks (cosmos#12988)
1a8cbbc 
## Description

ref: cosmos#12752 

- [x] Move some keeper tests into `tests/integration/gov/keeper`, see cosmos#12988 (comment)
- [x] Don't use simapp in `x/gov/keeper` tests, use mocks instead
- [x] Find 0 "simapp" occurence in x/gov/keeper. (Note: other occurrences of simapp are removed in  cosmos#13043)



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this issue Oct 26, 2022
@amaury1093 @Wryhder
test(gov): Remove simapp references from module tests and simulatio…
6b56806 
…ns (cosmos#13043)

## Description

0 occurences of "simapp" in x/gov.

closes: cosmos#12752

- [x] Move some x/gov module tests (those in x/gov root folder) to tests/integration, as they rely on a new module x/distribution
- [x] convert rest of x/gov module tests to use depinject
- [x] remove simapp references from x/gov/simulations
- [x] 0 occurences of "simapp" in x/gov



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
@amaury1093
test(gov): Remove simapp references from module tests and simulatio…
476f842 
…ns (cosmos#13043)

## Description

0 occurences of "simapp" in x/gov.

closes: cosmos#12752

- [x] Move some x/gov module tests (those in x/gov root folder) to tests/integration, as they rely on a new module x/distribution
- [x] convert rest of x/gov module tests to use depinject
- [x] remove simapp references from x/gov/simulations
- [x] 0 occurences of "simapp" in x/gov



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaury1093 amaury1093

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(gov): Remove simapp references from module tests and simulations cosmos/cosmos-sdk
2 participants
@amaury1093 @julienrbrt