fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e error in a ErrInvalidProposalContent (instead of ErrNoProposalHandlerExists).
|
I looked into adding a unit test for this, but it looked like it would be a lot of extra work for a thing named "legacy". If one is required, please point me to a legacy gov proposal message that I might utilize to trigger this case. |
|
I'm uncertain if this counts as an API breaking or state machine breaking change. Please advice and I'll update this PR/changelog if needed. |
…eturn it. Otherwise, wrap it as a ErrInvalidProposalContent.
Codecov Report
@@ Coverage Diff @@
## main #13051 +/- ##
==========================================
- Coverage 55.58% 55.58% -0.01%
==========================================
Files 644 644
Lines 54954 54956 +2
==========================================
+ Hits 30546 30547 +1
- Misses 21938 21939 +1
Partials 2470 2470
|
alexanderbez
approved these changes
Aug 25, 2022
|
Thanks for all the amazing work @SpicyLemon 🙏 |
alexanderbez
approved these changes
Aug 26, 2022
Eengineer1
added a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
commit d11196a Author: Robert Zaremba <robert@zaremba.ch> Date: Fri Aug 26 20:05:39 2022 +0200 deps: bump gin-gonic (cosmos#13061) Co-authored-by: Julien Robert <julien@rbrt.fr> commit 20b947e Author: Daniel Wedul <github@wedul.com> Date: Fri Aug 26 11:29:58 2022 -0600 fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (cosmos#13051) * [13030]: When a legacy gov proposal fails it's handler check, wrap the error in a ErrInvalidProposalContent (instead of ErrNoProposalHandlerExists). * [13030]: Add changelog entry. * [13030]: If the error is already a ErrNoProposalHandlerExists, just return it. Otherwise, wrap it as a ErrInvalidProposalContent. Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> commit fc7ee0b Author: Amaury <1293565+amaurym@users.noreply.github.com> Date: Thu Aug 25 22:15:44 2022 +0200 test(gov): Refactor x/gov keeper tests to use mocks (cosmos#12988) ## Description ref: cosmos#12752 - [x] Move some keeper tests into `tests/integration/gov/keeper`, see cosmos#12988 (comment) - [x] Don't use simapp in `x/gov/keeper` tests, use mocks instead - [x] Find 0 "simapp" occurence in x/gov/keeper. (Note: other occurrences of simapp are removed in cosmos#13043) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) commit 1fb6f0b Author: Daniel Wedul <github@wedul.com> Date: Thu Aug 25 13:43:40 2022 -0600 feat(x/auth): Add auth sim decoder case for AccountNumberStoreKeyPrefix (cosmos#13048) * [13028]: Add auth sim decoder case for AccountNumberStoreKeyPrefix (and a unit test case for it). * [13028]: Add changelog entry. commit 5e4651e Author: Daniel Wedul <github@wedul.com> Date: Thu Aug 25 13:17:46 2022 -0600 feat(x/authz): Add the GetAuthorization function. (cosmos#13047) * [13027]: Create the GetAuthorization function (in the authz module). * [13027]: Add unit tests for the new GetAuthorization function. * [13027]: Add changelog entry. commit c73171f Author: Julien Robert <julien@rbrt.fr> Date: Thu Aug 25 17:54:50 2022 +0200 fix: missing return statement in BaseApp.Query (cosmos#13046) ## Description Closes: cosmos#13040 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) commit e1999e4 Author: JayT106 <JayT106@users.noreply.github.com> Date: Thu Aug 25 17:09:52 2022 +0800 fix: exporting the blockParams regression (cosmos#13029) ## Description Closes: cosmos#13024 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) commit 6af89d6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 23:13:11 2022 +0200 build(deps): Bump github.com/golangci/golangci-lint from 1.48.0 to 1.49.0 (cosmos#13013) * build(deps): Bump github.com/golangci/golangci-lint Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.48.0...v1.49.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * updates Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> commit d8a7dbd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 21:47:14 2022 +0200 build(deps): Bump google.golang.org/grpc in /client/v2 (cosmos#13021) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.48.0...v1.49.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4fbd246 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 21:31:50 2022 +0200 build(deps): Bump github.com/cosmos/cosmos-sdk in /store/tools/ics23 (cosmos#13020) Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.46.0 to 0.46.1. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.46.1/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.46.0...v0.46.1) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 55307d6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 21:02:14 2022 +0200 build(deps): Bump google.golang.org/grpc in /errors (cosmos#13017) commit 4d2fc82 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 20:48:36 2022 +0200 build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 in /orm (cosmos#13016) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.48.0...v1.49.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0a5647e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 19:23:13 2022 +0200 build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 in /api (cosmos#13015) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.48.0...v1.49.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 149787b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 24 18:27:37 2022 +0200 build(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 (cosmos#13014) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.48.0...v1.49.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
…egacy handler returns an error. (cosmos#13051) * [13030]: When a legacy gov proposal fails it's handler check, wrap the error in a ErrInvalidProposalContent (instead of ErrNoProposalHandlerExists). * [13030]: Add changelog entry. * [13030]: If the error is already a ErrNoProposalHandlerExists, just return it. Otherwise, wrap it as a ErrInvalidProposalContent. Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
|
@alexanderbez May I ask if it's ok to backport this error fix to v0.46.x? |
yihuang
pushed a commit
to yihuang/cosmos-sdk
that referenced
this pull request
Apr 3, 2023
…egacy handler returns an error. (backport cosmos#13051) * [13030]: When a legacy gov proposal fails it's handler check, wrap the error in a ErrInvalidProposalContent (instead of ErrNoProposalHandlerExists). * [13030]: Add changelog entry. * [13030]: If the error is already a ErrNoProposalHandlerExists, just return it. Otherwise, wrap it as a ErrInvalidProposalContent. Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
19 tasks
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this pull request
May 30, 2023
…l when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" This reverts commit f89d955.
19 tasks
yihuang
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
May 30, 2023
…l when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" This reverts commit f89d955. Update CHANGELOG.md changelog
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Jun 9, 2023
* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <huang@crypto.com> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <marbar3778@yahoo.com> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <marbar3778@yahoo.com> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <julien@rbrt.fr> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo Medica <facundomedica@gmail.com> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Jun 9, 2023
* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <huang@crypto.com> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <marbar3778@yahoo.com> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <marbar3778@yahoo.com> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <julien@rbrt.fr> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo Medica <facundomedica@gmail.com> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Jun 9, 2023
* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…egacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…oposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13030
When a legacy proposal is given to
SubmitProposalthat fails when run through the handler on the cached context, wrap the error asErrInvalidProposalContentinstead ofErrNoProposalHandlerExists.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdincluded comments for documenting Go codeN/Aupdated the relevant documentation or specificationN/AReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change