Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's no check for chain-id in TxBuilder.SignStdTx #3945

Closed
wangjj9219 opened this issue Mar 20, 2019 · 0 comments · Fixed by #3946
Closed

There's no check for chain-id in TxBuilder.SignStdTx #3945

wangjj9219 opened this issue Mar 20, 2019 · 0 comments · Fixed by #3946

Comments

@wangjj9219
Copy link
Contributor

wangjj9219 commented Mar 20, 2019 •
edited
Loading

gaiacli tx sign use function TxBuilder.SignStdTx to sign tx, but there's no check for chain-id. If sign a tx without flag chain-id, then broadcast the signedTx, will report signature verification faild.

I see the check for chain-id in TxBuilder.BuildSignMsg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

There's no check for chain-id in TxBuilder.SignStdTx #3945 wangjj9219/cosmos-sdk
1 participant
@wangjj9219