feat!: make grant expiration optional

[robert-zaremba]

Description

Closes: #11095

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #11060 (0bce508) into master (20735e7) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #11060      +/-   ##
==========================================
+ Coverage   65.86%   65.89%   +0.03%     
==========================================
  Files         675      675              
  Lines       69773    69789      +16     
==========================================
+ Hits        45955    45988      +33     
+ Misses      21118    21100      -18     
- Partials     2700     2701       +1     

Impacted Files	Coverage Δ
x/authz/keeper/keys.go	95.08% <ø> (ø)
x/authz/simulation/operations.go	66.97% <57.89%> (+1.53%)	⬆️
x/authz/keeper/keeper.go	69.75% <65.51%> (-0.44%)	⬇️
types/coin.go	93.47% <100.00%> (+0.06%)	⬆️
types/query/filtered_pagination.go	81.57% <100.00%> (+0.24%)	⬆️
x/authz/authorization_grant.go	65.71% <100.00%> (-1.86%)	⬇️
x/authz/migrations/v046/store.go	70.45% <100.00%> (+1.40%)	⬆️
x/authz/msgs.go	62.09% <100.00%> (ø)
x/authz/simulation/genesis.go	94.44% <100.00%> (+0.69%)	⬆️
crypto/keys/internal/ecdsa/privkey.go	82.45% <0.00%> (-1.76%)	⬇️
... and 5 more

[robert-zaremba]

I've changed the default here to zero = no expiration time.
Maybe we would like to explicitly require the value? In that case:

• 0 would be not allowed
• -1 = no expire date

[amaury1093]

I think 0 == no expiration time makes the most sense.

Alternatively we can do:

• 0 == no expiry
• default is -1
• all negative values are not allowed

[robert-zaremba]

Alternatively we can do: 0 == no expiry; default is -1

If we want to make the CLI param required, the I prefer -1 as no expire, this is because 0 would mean "default", and we don't want default (from the user perspective).

all negative values are not allowed

Now, all values < blocktime().unix() are not allowed , except zero.

[amaury1093]

i was thinking:

Suggested change

	cmd.Flags().Int64(FlagExpiration, 0, "Expire time as Unix timestamp. Set zero (0) for no expiry. Default is 0.")
	cmd.Flags().Int64(FlagExpiration, -1, "Expire time as Unix timestamp. Set zero (0) for no expiry.")

But tbh -1 = no expire date sounds good to me too, if there's a help message.

[robert-zaremba]

bummer! calling a rand here will cause sim tests to fail :( This is because our simulation tests don't simulate much - they are almost 'pre defined': we have one grant message, one exec and one revoke. it's basically one premade scenario with lot of boilerplate.

[blushi]

Implementation looks good to me, pending simulations

[amaury1093]

Approving pending sims test fix, I suppose related to #11060 (comment)

[atheeshp]

lgtm, except sims & few nits.

[robert-zaremba]

Wow, there is a weird convolution, no idea why this test is failing:

    validator_test.go:476: 
                Error Trace:    validator_test.go:476
                Error:          Not equal: 
                                expected: 2
                                actual  : 3
                Test:           TestGetValidatorSortingMixed

[robert-zaremba]

It is also failing in master

[amaury1093]

@robert-zaremba It's fixed on master now