feat: grpc-only mode #11430
Merged
feat: grpc-only mode #11430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alexanderbez
added
the
C: gRPC
alexanderbez
requested review from
sahith-narahari,
robert-zaremba,
amaury1093 and
tac0turtle
and removed request for
aaronc
robert-zaremba
approved these changes
Mar 23, 2022
atheeshp
approved these changes
Mar 23, 2022
tac0turtle
approved these changes
Mar 24, 2022
| @@ -96,6 +94,12 @@ will not be able to commit subsequent blocks. | |||
|
|
|||
| For profiling and benchmarking purposes, CPU profiling can be enabled via the '--cpu-profile' flag | |||
| which accepts a path for the resulting pprof file. | |||
|
|
|||
| The node may be started in a 'query only' mode where only the gRPC and JSON HTTP | |||
There was a problem hiding this comment.
Are the queries from Tendermint supported in this mode? Stuff like block?
There was a problem hiding this comment.
No, this is gRPC only mode. The doc and implementation states Tendermint is disabled (i.e. not started). Tendermint cannot be supported.
There was a problem hiding this comment.
Does it sync new state though?
There was a problem hiding this comment.
No, because again, Tendermint is not running. This just serves existing data via gRPC.
There was a problem hiding this comment.
Ahhh yeah, thank you & sorry for the dumb question. 😁
There was a problem hiding this comment.
No such thing :p
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
* updates * lint++ * updates * updates * updates * updates * cl++ * updates Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 1880a7d) # Conflicts: # CHANGELOG.md # server/start.go
alexanderbez
pushed a commit
that referenced
this pull request
Mar 27, 2022
This was referenced May 19, 2022
JimLarson
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Jul 7, 2022
randy75828
pushed a commit
to Switcheo/cosmos-sdk
that referenced
this pull request
Aug 10, 2022
randy75828
pushed a commit
to Switcheo/cosmos-sdk
that referenced
this pull request
Aug 10, 2022
Eengineer1
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10796
grpc-only, which when enabled, starts the node with the gRPC and it's HTTP API variant only.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change