Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean TestRejectedProposalDeposits #11927

Closed
wants to merge 2 commits into from

Conversation

facundomedica
Copy link
Member

Description

This PR attempts to fix a flaky test. I did some cleanup of the function and so far I didn't encounter the issue again.

Closes: #11926


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #11927 (2b0e99b) into main (90272e3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11927      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files         676      675       -1     
  Lines       71346    71273      -73     
==========================================
- Hits        47105    47054      -51     
+ Misses      21559    21539      -20     
+ Partials     2682     2680       -2     
Impacted Files Coverage Δ
x/gov/client/testutil/deposits.go 88.19% <100.00%> (-5.92%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
core/appconfig/config.go
x/group/keeper/keeper.go 55.04% <0.00%> (+0.42%) ⬆️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@facundomedica facundomedica marked this pull request as draft May 10, 2022 22:49
@facundomedica
Copy link
Member Author

Closing in favor of #11940

@facundomedica facundomedica deleted the facu/refactor-rejected-prop-deposits branch August 30, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test: TestRejectedProposalDeposits
1 participant