Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x/gov client deposits tests #11940

Merged
merged 4 commits into from May 11, 2022
Merged

Conversation

facundomedica
Copy link
Member

Description

These tests were testing some odd conditions which shouldn't be possible in this module. Why they were passing? Because the test code had bugs itself. Check the issues below for more details.

Closes: #11936
Closes: #11926


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica requested a review from a team as a code owner May 11, 2022 17:31
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #11940 (ca1354e) into main (98710db) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11940      +/-   ##
==========================================
- Coverage   66.00%   65.97%   -0.03%     
==========================================
  Files         676      676              
  Lines       71333    71307      -26     
==========================================
- Hits        47080    47048      -32     
- Misses      21570    21578       +8     
+ Partials     2683     2681       -2     
Impacted Files Coverage Δ
x/gov/client/testutil/deposits.go 90.27% <100.00%> (-3.84%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/group/keeper/keeper.go 54.62% <0.00%> (-0.43%) ⬇️

@alexanderbez alexanderbez merged commit f9febea into main May 11, 2022
@alexanderbez alexanderbez deleted the facu/fix-gov-deposits-tests branch May 11, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/gov client deposits tests are wrong Fix flaky test: TestRejectedProposalDeposits
2 participants