chore(types): add MustAccAddressFromBech32 util func

[fedekunze]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #12201 (2f1512c) into main (4e6545b) will increase coverage by 0.08%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main   #12201      +/-   ##
==========================================
+ Coverage   66.07%   66.16%   +0.08%     
==========================================
  Files         672      672              
  Lines       71046    70990      -56     
==========================================
+ Hits        46946    46971      +25     
+ Misses      21435    21382      -53     
+ Partials     2665     2637      -28     

Impacted Files	Coverage Δ
simapp/export.go	11.94% <0.00%> (+0.17%)	⬆️
types/address.go	65.76% <0.00%> (-1.01%)	⬇️
types/tx/types.go	0.00% <0.00%> (ø)
x/bank/keeper/msg_server.go	3.03% <0.00%> (+0.04%)	⬆️
x/distribution/keeper/genesis.go	13.04% <0.00%> (+0.36%)	⬆️
x/group/msgs.go	53.67% <0.00%> (+1.46%)	⬆️
x/group/types.go	48.79% <0.00%> (+0.35%)	⬆️
x/staking/keeper/val_state_change.go	64.77% <0.00%> (+0.48%)	⬆️
server/rosetta/converter.go	56.75% <100.00%> (+0.46%)	⬆️
x/auth/tx/builder.go	82.05% <100.00%> (+1.07%)	⬆️
... and 30 more

[robert-zaremba]

In the past we were trying to remove / limit panics. I know it can reduce the code, but it hides the error in panic down stream.
Should we revisit this?
cc: @aaronc , @alexanderbez

[alexanderbez]

Well the code paths that call this new API panic'd anyway and in cases of BeginBlock/EndBlock, they need to panic. So I don't see a need to revert this. Those that want to handle the errors gracefully still can call the original error-returning API.

[robert-zaremba]

IMO it encourages a wrong style. Panic, if needed, should happen when there is no way to recover.
Moreover testing is harder. Because we can't check an error, instead we need to use recover. If we add more error aggregation primitives, then panics will conflict with that road.
In the PR most of the updates are related to GetSigners.... which are not related to BeginBlock etc...

[alexanderbez]

IMO it encourages a wrong style. Panic, if needed, should happen when there is no way to recover.

That's exactly what's happening here. This API provides a convenience method to avoid if err != nil { panic(...) } boilerplate, i.e. this will be used in code paths that already panic.

[robert-zaremba]

Probably i didn't express it correctly. I don't think it's good to add that method to a public API. Having it internal is OK. It's already a technical debt that we don't return errors and panic instead.
I'm worried that it will be used in other places instead of returning an error.

[alexanderbez]

It's the developer's responsibility to ensure they handle errors correctly IMO.