Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add message index event attribute to authz message execution (backport #12668) #12673

Merged
merged 4 commits into from Jul 22, 2022

Commits on Jul 21, 2022

  1. feat: add message index event attribute to authz message execution (#…

    …12668)
    
    ## Description
    
    It's impossible currently for operators or clients to understand what events emitted from messages executed via `MsgExec` correspond to exactly what messages. This PR adds a message index attribute to each event emitted by a message via `MsgExec`.
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit afab2f3)
    
    # Conflicts:
    #	CHANGELOG.md
    #	x/authz/keeper/keeper.go
    #	x/authz/keeper/msg_server.go
    alexanderbez authored and mergify[bot] committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    884e2dc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. updates

    alexanderbez committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    7f3c8ae View commit details
    Browse the repository at this point in the history
  2. updates

    alexanderbez committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    09c31e2 View commit details
    Browse the repository at this point in the history
  3. updates

    alexanderbez committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    b7ba1ff View commit details
    Browse the repository at this point in the history