Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky tests + new method RetryForBlocks #14609

Merged
merged 19 commits into from
Jan 17, 2023
Merged

test: fix flaky tests + new method RetryForBlocks #14609

merged 19 commits into from
Jan 17, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jan 13, 2023 •
edited
Loading

Description

Closes: #14520

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jan 13, 2023
@facundomedica facundomedica marked this pull request as ready for review January 13, 2023 19:17
@facundomedica facundomedica requested a review from a team as a code owner January 13, 2023 19:17
@github-prbot github-prbot requested review from a team, amaury1093 and testinginprod and removed request for a team January 13, 2023 19:18
alexanderbez
alexanderbez suggested changes Jan 13, 2023
View reviewed changes
tests/e2e/staking/suite.go Outdated Show resolved Hide resolved
tests/e2e/staking/suite.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! How do you decide how many blocks you need to wait in tests?

@julienrbrt
Copy link
Member

Now that you call tm it closes this right: #14520?

@facundomedica
Copy link
Member Author

This is great! How do you decide how many blocks you need to wait in tests?

It's an arbitrary number tbh, just a safe guess I suppose. I don't think a tx would take more than 2 blocks, but to be safe I've used 3. You will get the response before that if it's available anyway.

There's one that has 10 blocks because there was a comment using that // Wait maximum 10 blocks, or else fail test..

My strategy would be that any time we encounter a flaky test, we replace the WaitForNextBlock with RetryForBlocks.

@alexanderbez alexanderbez enabled auto-merge (squash) January 17, 2023 15:37
@alexanderbez alexanderbez merged commit 7505c18 into main Jan 17, 2023
@alexanderbez alexanderbez deleted the facu/fix-flaky-tests branch January 17, 2023 15:58
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 20, 2023
@facundomedica @mergify
test: fix flaky tests + new method RetryForBlocks (#14609)
e93c00a 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 7505c18)

# Conflicts:
#	CHANGELOG.md
#	testutil/network/network.go
facundomedica added a commit that referenced this pull request Mar 20, 2023
@mergify @facundomedica @tac0turtle
test: fix flaky tests + new method RetryForBlocks (backport #14609) (#…
e350809 
…15469)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WaitForHeight test util doesn't check the node's "local" height
4 participants
@facundomedica @julienrbrt @tac0turtle @alexanderbez