refactor: reduce tendermint deps #14616
Conversation
| @@ -0,0 +1,291 @@ | |||
| // MODIFIED BY TENDERMINT TO EXPOSE `salt` in `GenerateFromPassword`. | |||
There was a problem hiding this comment.
Basically re-add this to the repo as it was some years ago: https://github.com/cosmos/cosmos-sdk/tree/v0.22.0/crypto/keys/bcrypt
There was a problem hiding this comment.
Confirmed this file is the same as https://github.com/cosmos/cosmos-sdk/blob/v0.22.0/crypto/keys/bcrypt/bcrypt.go with only benign changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crypto/ledger/ledger_mock.go
Outdated
| @@ -1,6 +1,3 @@ | |||
| //go:build ledger && test_ledger_mock | |||
There was a problem hiding this comment.
TODO: make go test ./crypto/ledger/... -tags='ledger,test_ledger_mock' tests pass
EDIT: works
| @@ -0,0 +1,35 @@ | |||
| // Copyright 2011 The Go Authors. All rights reserved. | |||
There was a problem hiding this comment.
we should open an issue on how/if we can remove this file and use the canonical version
There was a problem hiding this comment.
I agree. I need to look at it more as well, as CI is not happy with this file too (there were no CI in tendermint/crypto).
I wonder if we should enhance it, or leave it as is and exclude it from linting.
EDIT: used nolint for having CI not complain, as this is a copy of the original.
There was a problem hiding this comment.
Relevant: tendermint/tendermint#3027, TM removed the use of their own fork some time ago.
github-prbot
requested review from
a team,
aaronc and
tac0turtle
and removed request for
a team
|
@odeke-em I would love if someone from your team could check this :) |
julienrbrt
added
backport/0.45.x
backport/0.46.x
Sure, kindly paging @elias-orijtech |
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| package bcrypt |
There was a problem hiding this comment.
Confirmed this file is identical to https://cs.opensource.google/go/x/crypto/+/master:bcrypt/base64.go.
| @@ -0,0 +1,291 @@ | |||
| // MODIFIED BY TENDERMINT TO EXPOSE `salt` in `GenerateFromPassword`. | |||
There was a problem hiding this comment.
Confirmed this file is the same as https://github.com/cosmos/cosmos-sdk/blob/v0.22.0/crypto/keys/bcrypt/bcrypt.go with only benign changes.
|
Given that it keeps the same behavior, and we backport that directly to point version of 0.45 and 0.46 and I think it could go directly to 0.47 final too instead of 0.47.1. |
julienrbrt
added
backport/v0.47.x
Just tested with my nano s and it works. |
(cherry picked from commit 44fbb0d) # Conflicts: # x/nft/go.mod # x/nft/go.sum
(cherry picked from commit 44fbb0d) # Conflicts: # crypto/ledger/ledger_mock.go # crypto/ledger/ledger_secp256k1.go # simapp/go.mod # simapp/go.sum # tests/go.mod # tests/go.sum # x/nft/go.mod
(cherry picked from commit 44fbb0d) # Conflicts: # crypto/ledger/ledger_mock.go # crypto/ledger/ledger_secp256k1.go # go.mod # go.sum # simapp/go.mod # simapp/go.sum # tests/go.mod # tests/go.sum # x/nft/go.mod # x/nft/go.sum
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
…mos#14663)" This reverts commit 2645664.
Description
Reduces dependencies on tendermint packages due to the uncertainty about the tendermint github org:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change