Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Textual SignModeHandler #14650

Merged
merged 12 commits into from
Jan 18, 2023
Merged

feat: Add Textual SignModeHandler #14650

merged 12 commits into from
Jan 18, 2023

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jan 17, 2023

Description

Closes: #13700

Tests will be added once the client-side infra is done, tracked by #13747


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as ready for review January 17, 2023 13:51
@amaury1093 amaury1093 requested a review from a team as a code owner January 17, 2023 13:51
@github-prbot github-prbot requested review from a team, facundomedica and atheeshp and removed request for a team January 17, 2023 13:52
x/auth/tx/config.go Show resolved Hide resolved
x/tx/textual/any.go Outdated Show resolved Hide resolved
amaury1093 and others added 2 commits January 17, 2023 16:48
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@julienrbrt
Copy link
Member

Do you think there is something to be updated here https://docs.cosmos.network/main/run-node/txs and https://docs.cosmos.network/main/modules/auth/tx given that it's now wired?

@amaury1093
Copy link
Contributor Author

Do you think there is something to be updated here https://docs.cosmos.network/main/run-node/txs and https://docs.cosmos.network/main/modules/auth/tx given that it's now wired?

Textual is wired but not enabled by default, and I would keep it like this. I would even avoid any docs on how to enable it right now, as we're still testing it.

My initial plan was to finish Textual QA first, then enable it. I have an item in #11970 to add docs during the QA phase.

@amaury1093 amaury1093 mentioned this pull request Jan 18, 2023
39 tasks
@amaury1093 amaury1093 enabled auto-merge (squash) January 18, 2023 09:37
@amaury1093 amaury1093 merged commit 40f7e5d into main Jan 18, 2023
@amaury1093 amaury1093 deleted the am/13700-textual-handler branch January 18, 2023 09:56
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Textual SignModeHandler
3 participants