Implement SIGN_MODE_TEXTUAL #11970
Assignees
Labels
T:Epic
Epics
Comments
20 tasks
|
@AmauryM could you break out some of the bullet points into their own issues, We can start including some of them in our upcoming sprint |
|
Yeah I can do that |
This was referenced Jul 18, 2022
This was referenced Sep 5, 2022
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Oct 15, 2022
## Description Refs: #11970 Changes target of `SIGN_MODE_TEXTUAL` rendering to be a structured datatype instead of lines of ASCII text. This avoids the complexities of in-band, signaling and allows more capable signing devices not to be hindered by the limitations of those less capable. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [X] added `!` to the type prefix if API or client breaking change - [X] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [X] provided a link to the relevant issue or specification - [X] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [X] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [X] included comments for [documenting Go code](https://blog.golang.org/godoc) - [X] updated the relevant documentation or specification - [X] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed NOTE: changelog intentionally omitted - we'll add an entry when #11970 is complete. ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
2 tasks
mergify bot
pushed a commit
that referenced
this issue
Oct 23, 2022
## Description Refs: #11970 Minor fixups to architecture docs. No major semantic changes are intended. --- ### Author Checklist I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This was referenced Oct 24, 2022
1 task
19 tasks
This was referenced Jan 17, 2023
19 tasks
19 tasks
19 tasks
|
This is a great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Implement SIGN_MODE_TEXTUAL as described in #10701. If you want to help, please contact @AmauryM to be part of the working group.
Board view
Proposal
We propose to do Golang and JS implementations in parallel, and update the SPEC if anything needs to be changed.
Step 1: Value Renderers
FormatSee specification in ADR-050 Annex 1. Each item is checked when both Golang and JavaScript implementations are done, using the same test cases.
sdk.Coinandsdk.CoinsTEXTUAL Value Renderer forCoinandCoins#12708bytes#12711google.Protobuf.TimestampTEXTUAL Value Renderers forgoogle.protobuf.Timestamp#12709google.Protobuf.DurationTEXTUAL Value Renderers forgoogle.protobuf.Duration#12710messages TEXTUAL Value Renderers for Protobufmessage#12713repeatedTEXTUAL Value Renderers for Protobufrepeatedfields #12714google.protobuf.AnyTEXTUAL Value Renderers forgoogle.Protobuf.Any#12715Txstruct #13579anypb.Anytype url prefix "type.googleapis.com" #13669sdk.Coinsparsing #13153Addressfield expert #14651Key+Valueinstead of simplyText#14665Step 2: Wire up to sign mode handlers
[]Screen#13647GetSignBytes: add Context arg #13646By this stage, we can do a E2E signing flow with Ledger and SIGN_MODE_TEXTUAL. Edit: Done in an exploration PR #13734.
Step 3: QA and docs
For Admin Use
The text was updated successfully, but these errors were encountered: