feat: add a new command to list supported algos #14655
Conversation
github-prbot
requested review from
a team,
aaronc and
likhita-809
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -167,7 +177,7 @@ | |||
| args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID) | |||
| args.minGasPrices, _ = cmd.Flags().GetString(server.FlagMinGasPrices) | |||
| args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -134,7 +144,7 @@ | |||
| args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome) | |||
| args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress) | |||
| args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -113,7 +123,7 @@ | |||
| outputFormat := ctx.OutputFormat | |||
|
|
|||
| keyringAlgos, _ := kb.SupportedAlgorithms() | |||
| algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm) | |||
| algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for") | ||
|
|
||
| // support old flags name for backwards compatibility | ||
| cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
There was a problem hiding this comment.
cmd.PersistentFlags() should have been cmd.Flags() and my fat fingers merged from my phone.
I can fix in on some unrelated incoming PR.
| f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for") | ||
|
|
||
| // support old flags name for backwards compatibility | ||
| cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
There was a problem hiding this comment.
cmd.PersistentFlags() should have been cmd.Flags() and my fat fingers merged from my phone.
I can fix in on unrelated incoming PR.
There was a problem hiding this comment.
|
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
(cherry picked from commit 5233d5e) # Conflicts: # CHANGELOG.md # simapp/simd/cmd/testnet.go
Description
Closes: #8886
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change