Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(depinject): send logging to file instead of stderr #14825

Merged
merged 1 commit into from
Jan 27, 2023
Merged

feat(depinject): send logging to file instead of stderr #14825

merged 1 commit into from
Jan 27, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 27, 2023 •
edited
Loading

Description

Closes: #12575

This should make working with depinject a bit nicer.

Needs to be tested manually.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review January 27, 2023 19:10
@aaronc aaronc requested a review from a team as a code owner January 27, 2023 19:10
@aaronc aaronc mentioned this pull request Jan 27, 2023
Merged
19 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 27, 2023
View reviewed changes
depinject/debug.go
return Logger(func(s string) {
var err error
if f == nil {
f, err = os.Create(filename)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
tac0turtle
tac0turtle approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

julienrbrt
julienrbrt approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@julienrbrt julienrbrt merged commit 1ad8e86 into main Jan 27, 2023
@julienrbrt julienrbrt deleted the aaronc/12575-silence-depinject-logging branch January 27, 2023 20:10
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@aaronc @tsenart
feat(depinject): send logging to file instead of stderr (cosmos#14825)
8786b8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp Awaiting requested review from atheeshp

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

depinject AutoDebug should send log messages to file instead of StdErr
3 participants
@aaronc @tac0turtle @julienrbrt